Closed
Conversation
hartig
requested changes
Feb 12, 2026
Member
hartig
left a comment
hartig
left a comment
There was a problem hiding this comment.
This PR presents a great piece of work. Thanks a lot for it!
As we discussed today, however, it is better to move this into a separate repo. Therefore, I will close the PR without merging.
Can I already delete the branch as well or do you still want to keep it around until you have copied the files over?
| * unit tests that access servers on the actual Web. | ||
| */ | ||
| public static boolean skipLiveWebTests = true; | ||
| public static boolean skipLiveWebTests = false; |
Member
There was a problem hiding this comment.
Please revert to the "default" value.
Suggested change
| public static boolean skipLiveWebTests = false; | |
| public static boolean skipLiveWebTests = true; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a FedBench-based evaluation setup for correctness and performance analysis.
A new test suite executes the FedBench queries using the Fed-I and Fed-II federation configurations (Heling & Acosta), covering 9 datasets exposed via SPARQL, TPF, and brTPF, and 25 queries from cross-domain, life-science, and linked-data workloads. Source assignments are manually derived using the FedX source selection approach. Query results are validated against expected outputs.
The tests are disabled by default, as they depend on live endpoints and a specific federation setup.
Additionally, a standalone bash script is included to run all queries and measure query processing time, planning time, compilation time, and execution time. This script is mainly intended for performance evaluation, e.g., assessing the impact of architectural changes or optimizations.
Note: Queries
fed1-ls-7.rqandfed2-ls-7.rqhave been commented out for now (see #496)