ARRISEOS-46417 CachedResourceLoader: return early if document is null#444
Open
tomasz-karczewski-red wants to merge 1 commit intolgi-masterfrom
Open
ARRISEOS-46417 CachedResourceLoader: return early if document is null#444tomasz-karczewski-red wants to merge 1 commit intolgi-masterfrom
tomasz-karczewski-red wants to merge 1 commit intolgi-masterfrom
Conversation
This is to prevent nullptr-related crashes
tomasz-karczewski-red
requested review from
amol-virnodkar-infosys and
marcin-mielczarczyk-red
marcin-mielczarczyk-red
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to prevent nullptr-related crashes with stack like:
0 libWPEWebKit-0.1.so.2!WebCore::CachedResourceLoader::allowedByContentSecurityPolicy(WebCore::CachedResource::Type, WebCore::URL const&, WebCore::ResourceLoaderOptions const&, WebCore::ContentSecurityPolicy::RedirectResponseReceived) const [CachedResourceLoader.cpp : 439 + 0x0]
1 libWPEWebKit-0.1.so.2!WebCore::CachedResourceLoader::canRequestAfterRedirection(WebCore::CachedResource::Type, WebCore::URL const&, WebCore::ResourceLoaderOptions const&) const [CachedResourceLoader.cpp : 428 + 0x13]
2 libWPEWebKit-0.1.so.2!WebCore::SubresourceLoader::willSendRequestInternal(WebCore::ResourceRequest&&, WebCore::ResourceResponse const&, WTF::CompletionHandler<void(WebCore::ResourceRequest&&)>&&) [SubresourceLoader.cpp : 247 + 0xf]
3 libWPEWebKit-0.1.so.2!WebKit::WebResourceLoader::willSendRequest(WebCore::ResourceRequest&&, WebCore::ResourceResponse&&) [WebResourceLoader.cpp : 94 + 0x1]
4 libWPEWebKit-0.1.so.2!void IPC::handleMessage<Messages::WebResourceLoader::WillSendRequest, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::(WebCore::ResourceRequest&&, WebCore::ResourceResponse&&)>(IPC::Decoder&, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::* (WebCore::ResourceRequest&&, WebCore::ResourceResponse&&)) [HandleMessage.h : 41 + 0x19]
5 libWPEWebKit-0.1.so.2!WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::Decoder&) [WebResourceLoaderMessageReceiver.cpp : 49 + 0x13]