ARRISAPOL-3614 wpe: fix in GstState handling#464
Draft
tomasz-karczewski-red wants to merge 1 commit intolgi-wpe-2.38-23Q4from
Draft
ARRISAPOL-3614 wpe: fix in GstState handling#464tomasz-karczewski-red wants to merge 1 commit intolgi-wpe-2.38-23Q4from
tomasz-karczewski-red wants to merge 1 commit intolgi-wpe-2.38-23Q4from
Conversation
MediaPlayerPrivateGStreamer::changePipelineState assumes that when pipeline state change is requested, and the requested state is same as current state, that request can be rejected. What was not taken into account is that even if newState == currentState, there might still be some other state pending, and the pipeline state might still need to be updated in such case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediaPlayerPrivateGStreamer::changePipelineState assumes that when pipeline state change is requested, and the requested state is same as current state, that request can be rejected. What was not taken into account is that even if newState == currentState, there might still be some other state pending, and the pipeline state might still need to be updated in such case.