add push_to_hub support 🤗#2
Closed
Linoy Tsaban (linoytsaban) wants to merge 4 commits intoLightricks:mainfrom
Closed
add push_to_hub support 🤗#2Linoy Tsaban (linoytsaban) wants to merge 4 commits intoLightricks:mainfrom
push_to_hub support 🤗#2Linoy Tsaban (linoytsaban) wants to merge 4 commits intoLightricks:mainfrom
Conversation
Ofir Bibi (ofirbb)
requested changes
Mar 24, 2025
Member
Ofir Bibi (ofirbb)
left a comment
Ofir Bibi (ofirbb)
left a comment
There was a problem hiding this comment.
Nice hook into making stuff public easily.
| # Upload artifacts to hub if enabled | ||
| if cfg.hub.push_to_hub: | ||
| repo_id = cfg.hub.hub_model_id or Path(cfg.output_dir).name | ||
| repo_id = create_repo(token=cfg.hub.hub_token, repo_id=repo_id, exist_ok=True) |
Member
There was a problem hiding this comment.
Please add the base model parameter here.
You can either point to the general LTXV repo or go finegrain amd allow the user to set a specific version. Either works for me.
Contributor
Author
There was a problem hiding this comment.
added a model card now :), wdyt?
adjust `save_model_card` to include inference examples
Harel Cain (harelc)
pushed a commit
that referenced
this pull request
Mar 25, 2025
Add latent decoding script, add image support
adjust `save_model_card` to include inference examples
Collaborator
|
Thanks, Linoy Tsaban (@linoytsaban)! Naomi ken korem (@Naomi-Ken-Korem) has made slight adjustments to your changes and merged them in #28. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Congrats on the release, awesome work! 🎉
I added some smol changes to support automatic uploading of the weights to the hub, I think it can be great for discoverability of trained loras by the community :)