Fix: unwrap DDP before enabling gradient checkpointing for HF compatibility#31
Open
magictut (magicwang1111) wants to merge 1 commit intoLightricks:mainfrom
Open
Fix: unwrap DDP before enabling gradient checkpointing for HF compatibility#31magictut (magicwang1111) wants to merge 1 commit intoLightricks:mainfrom
magictut (magicwang1111) wants to merge 1 commit intoLightricks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces three key improvements:
Dependency Standardization
requirements.txtfile based on the originaluv.lockto ensure reproducible installations across environments.diffusers,accelerate,transformers, CUDA toolkits, and other core libraries.Support for Custom Master Port
--main_process_portoption inscripts/train_distributed.pyto allow explicit control over the master port used by Accelerate’s distributed launcher.python scripts/train_distributed.py
configs/your_config.yaml
--num_processes 2
--main_process_port 29600
**Fix for HF DDP Compatibility
In src/ltxv_trainer/trainer.py, unwrap the base model from DistributedDataParallel before calling the gradient-checkpointing API.
Prevents the runtime AttributeError: 'DistributedDataParallel' object has no attribute 'enable_gradient_checkpointing'.