PR Summary: Fix Duplicate Output from fork() #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinCappos
requested changes
May 29, 2024
Member
JustinCappos
left a comment
JustinCappos
left a comment
There was a problem hiding this comment.
Does this problem only exist for stdout / stderr? What if they are duped to new fds? Do those need to be flushed as well / intead? What if stdout and stderr are redirected to new types of output (not the terminal)?
Can we add some tests for these cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the output from a program using the fork() system call was duplicated, resulting in unintended output. The problem was due to both the parent and child processes having the same iO buffers causing both to print to the standard output.
To resolve this, the following changes were made:
Added fflush(stdout); before the fork() call to ensure that the buffer is flushed, preventing any buffered output from being duplicated in the child process.
With these changes, the program now produces the correct and intended output, ensuring only the parent process prints "2!" while the child process exits immediately.
Issue link: Lind-Project/native_client#12