Skip to content

Crockford hyphens check #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martinheidegger wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Crockford hyphens check #5

martinheidegger wants to merge 2 commits into from

Conversation

@martinheidegger
Copy link

@martinheidegger martinheidegger commented Dec 14, 2021 •
edited
Loading

Crockford base32 spec mentions that

Hyphens (-) can be inserted into symbol strings.

and

An application may append a check symbol to a symbol string.

This PR adds support and test for these details.

Closes #4

Note: I also added some performance improvements for the crockford lookup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hyphens and check symbols are also valid in Crockford’s base 32.

1 participant

@martinheidegger