Skip to content

Conversation

@pablorsk
Copy link

  • Fix error Call to undefined function LinusU\Bitcoin\bcmul() in AddressValidator.php line 82: ext-bcmath required on composer.json)
  • gitattributes improved (don't download test folder when you run composer require linusu/bitcoin-address-validator)

@LinusU
Copy link
Owner

LinusU commented Jan 17, 2019

There seems to be a lot of changes in .gitattributes that doesn't apply to this project. I'm also not sure if export-ignore is the best solution since it will also affect when downloading the repo as a zip from GitHub.

Could you just edit the composer.json file in this PR, and then open additional issues if you want to change something else? thanks ☺️

@pablorsk
Copy link
Author

Hi LunuxU!

.gitattributes is not only for download .ZIP. .gitignore file is ideal for composer libraries. Check, for example, Laravel Framework repo: https://github.com/laravel/framework/blob/5.7/.gitattributes

On this case, for example, I dont need AddressValidatorTest.php on any of my projects.

Also, if you prefer different PR just for organizational reasons, tell me.

@pablorsk
Copy link
Author

pablorsk commented Aug 2, 2019

bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants