-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add 5.4.290 support, update docs #3347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: andypugh/2.9-rtai
Are you sure you want to change the base?
Add 5.4.290 support, update docs #3347
Conversation
5.4.290 fixes a lot of issues and should be the new replacement all around. Signed-off-by: Alec Ari <neotheuser@ymail.com>
|
Two things, 1) aren't the translations supposed to be handled through weblate and 2) what is it that makes the suggested change fail CI? |
|
I think it would be best to only fix the english docs, though I am not clear how this sort of thing would be expected to propagate through weblate. Also, do we actually have a 5.4.290-rtai kernel image? Note that we supply the kernel and linuxcnc packages as a set, so whilst I see some value in allowing 5.4.290 it is quite a lot more work to distribute it. I don't think we can really mention the 5.4.290 kernel in the docs if it isn't available to download? (ie, if it isn't in here: http://www.linuxcnc.org/dists/bookworm/base/binary-amd64/ ) |
|
@BsAtHome CI doesn't run an RTAI kernel. So it shouldn't even notice the changes to RTAI specific things. |
That is why I'm puzzled as to the complete CI failure. |
|
The issue is that my public 2.9-rtai branch, against which this patch is to be applied, doesn't actually build debs without parameters to the debian/configure command. And the CI.yml doesn't have those. |
|
I have added the new kernel, but not changed the docs yet as a separate commit. |
Yes, but only for master. I suggest to change only the adoc file (which is not included here) and do not touch the po files (this will probably cause merge conflicts and you don't want to solve them all one by one =) ). The pot file change can be done here, but this file is generated (manually), so there is no need to do this change manually. |
|
I am actually a bit worried now about the 5.4.290 kernel because when you load a config, not a sim, LinuxCNC crashes and it'll log you out and you'll get a black screen, and it seg faults a lot. I'm going to try the 5.4.290 kernel in Gentoo and see if it's any better. If 5.4.290 gives me trouble on Gentoo, I'll have to downgrade the kernel. 5.4.279 definitely works, so something may have happened between 5.4.279 and 5.4.290. |
|
Hi @NTULINUX, do you have an update on how to adjust the documentation? As already pointed out by others, it will be on Weblate contributors to update their respective language, so we can avoid conflicts in the version management. |
|
I would put this on hold for now because 5.4.290 is having issues with LinuxCNC+parallel port cards. The simulator and everything else works, but after using stepconfig and actually using the parallel port card, the system crashes. I need to downgrade the kernel but I have not yet had access to a machine with a parallel port card in awhile, and it will be a long time until I do. For the mean time, please use 5.4.279. |
5.4.290 fixes a lot of issues and should be the new replacement all around.