Support port forwarding in Python CLI #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuliren
approved these changes
May 6, 2025
Collaborator
tuliren
left a comment
tuliren
left a comment
There was a problem hiding this comment.
If users launch multiple models and want to expose the port locally, they must specify different ports, right? Otherwise, there will be conflicts. Can you update the README accordingly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
--portvariable on running model commands will only change the port within Docker container. This PR will force vLLM to be launched on port 9000 and forward them to the port assigned by users. By default, we don't expose this port because users are able to access the model through the labs Python API stack.