Skip to content

Don't NPE when config option is not specified #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pratikmallya wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Don't NPE when config option is not specified #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion jack-core/src/com/rapleaf/jack/DatabaseConnectionConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,18 @@ private static <T> T load(
if (result.isPresent()) {
return result.get();
} else {
String foundKeys;
if (map == null) {
foundKeys = "No keys found";
} else {
foundKeys = map.keySet().toString();
}
throw new RuntimeException(
"Unable to find required configuration " + readableName + ". Please set using one of:\n" +
"Environment Variable: " + envVar + "\n" +
"Java System Property: " + javaProp + "\n" +
"Entry in config/" + mapYmlFile + ".yml: " + mapKey + "\n" +
"Found following keys: " + map.keySet());
"Found following keys: " + foundKeys);
}
}

Expand Down