Centralize Auth Redirect Logic in AuthLayout Component #17
Conversation
…cks from LoginPage and SignupPage
Leon-JavaScript
added
the
Priority: Medium
There was a problem hiding this comment.
Pull request overview
This PR centralizes authentication redirect logic by moving the authentication check from individual LoginPage and SignupPage components into the shared AuthLayout component. This eliminates code duplication and ensures consistent behavior across authentication pages.
Changes:
- Moved authentication check and redirect logic from LoginPage and SignupPage to AuthLayout
- AuthLayout now checks if users are authenticated on mount and redirects to /projects if they are
- Removed duplicate useEffect hooks from both login and signup pages
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app/(auth)/layout.tsx | Added authentication check with useEffect hook that redirects authenticated users to /projects |
| src/app/(auth)/login/page.tsx | Removed duplicate authentication check logic now handled by layout |
| src/app/(auth)/signup/page.tsx | Removed duplicate authentication check logic now handled by layout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| useEffect(() => { | ||
| async function checkAuth() { | ||
| try { | ||
| const response = await fetch('/api/users/me', { | ||
| credentials: 'include', | ||
| }); | ||
|
|
||
| if (response.ok) { | ||
| // User is already authenticated, redirect to projects | ||
| router.push('/projects'); | ||
| } | ||
| } catch { | ||
| // User is not authenticated, stay on auth page | ||
| } | ||
| } | ||
|
|
||
| checkAuth(); | ||
| }, [router]); |
There was a problem hiding this comment.
The authentication check in the layout should include a loading state to prevent flashing the login/signup form before redirecting authenticated users. The dashboard layout (in src/app/(dashboard)/layout.tsx) implements this pattern correctly with an isChecking state that shows a loading indicator. Without this, users may briefly see the auth form before being redirected to /projects.
This PR moves the authentication check and redirect logic from the individual LoginPage and SignupPage components into the shared AuthLayout component.
Changes