Open
Conversation
Collaborator
|
@adjabaev , have you ran tests locally ? |
Author
|
I will take a look at the tests later today, I also did some modifications compared to this version that I might not have posted yet. But overall it works quite good I have been using it for 4 days on my infrastructure without having problems. |
Collaborator
|
Great, please update the PR once you are ready |
|
Hey @adjabaev any chance get this working / merged soon? :) |
tamassza
reviewed
Feb 5, 2026
| implementation project(':grpc-client-spring-boot-starter') | ||
|
|
||
| testImplementation 'org.springframework.boot:spring-boot-starter-aop' | ||
| testImplementation 'org.springframework.boot:spring-boot-starter-aop:4.0.0-M2' |
There was a problem hiding this comment.
Maybe use spring-boot-starter-aspectj instead?
For reference: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-4.0-Migration-Guide#aop-starter-pom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.