Env refactor#3
Open
kastork wants to merge 22 commits intoLonghouse-Games:masterfrom
kastork:env-refactor
Open
Conversation
Change POST Content-type to "application/json"
Member
|
If changing the content type has unintended consequences, then those are probably bugs :) |
Member
|
Gave this a read through and it looks good. I'll try to find some time this week to do some testing and then I'll merge it. Thanks! 🍻 |
Author
|
"If changing the content type has unintended consequences, then those are probably bugs :)" For sure. But such bugs don't belong to this project :) God only knows what Liferay wants. |
Ignore jetbrains project files.
… prepare for plans to have EGSNotifier maintain an AMQP connection rather than making web service requests.
…sometimes the separate update got to the lobby before the 'new/' response was processed.
…erate through all roles.
Additional logging. Auto-formatter. JSLint corrections.
Provide additional configuration options
Merge MOVES changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do give this a careful once-over. I'm a little concerned that changing the Content-type of notification posts from 'text/plain' to 'application/json' might have unintended consequences. I did it because the new lobby pays attention and won't parse a JSON body if the Content-type isn't correct.