feat(auth): automatic session refresh#102
Open
D-Heger wants to merge 1 commit intoLovelessCodes:releasefrom
Open
feat(auth): automatic session refresh#102D-Heger wants to merge 1 commit intoLovelessCodes:releasefrom
D-Heger wants to merge 1 commit intoLovelessCodes:releasefrom
Conversation
…tion before game launch
LovelessCodes
requested changes
Oct 13, 2025
Owner
LovelessCodes
left a comment
LovelessCodes
left a comment
There was a problem hiding this comment.
Pretty good, just needs to be usable without signing in to an account.
| return useMutation({ | ||
| ...props, | ||
| mutationFn: async ({ name, ip, password, installationId, pub }) => { | ||
| // Validate that a user is selected before launching |
Owner
There was a problem hiding this comment.
I'm not sure sure about them having to select a user, before connecting to a server - Story Forge should be possible to use without signing-in through Story Forge.
| invoke("play_game", { options: { installation_id: id, save } }), | ||
| mutationFn: ({ id, save }) => { | ||
| // Validate that a user is selected before launching | ||
| if (!selectedUser) { |
Owner
There was a problem hiding this comment.
Same thing as in use-connect-to-server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Related Issues
Checklist
I have linked related issues using #I have updated documentation where appropriateReviewers