Skip to content
This repository was archived by the owner on Sep 10, 2022. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9486 commits
Select commit Hold shift + click to select a range
6941321
Fix supportsViewer default documentation (#18942)
Oct 24, 2018
b5cae4f
✨Adding upScore as an analytics vendor to amp-analytics (#18734)
suransandi Oct 24, 2018
66079ac
✅Introduce more amp-pixel integration tests (#18792)
calebcordry Oct 25, 2018
4e2a4f0
Url-Replacement: check for false (#18926)
calebcordry Oct 25, 2018
55af1fe
🐛Fix IE11 with a basic polyfill (#18941)
cvializ Oct 25, 2018
db2d587
♻️ Move main template to JS (#18950)
alanorozco Oct 25, 2018
b6a76aa
stop report error (#18793)
zhouyx Oct 25, 2018
8895642
♻️ Render file list in AMP ⚡ (#18969)
alanorozco Oct 25, 2018
bce1b07
Strip out amp_kit in AMP runtime. (#18427)
mazaninfardi Oct 25, 2018
a5a1ab4
Add WorkletAnimation to amp-animation.js (#18826)
nainar Oct 25, 2018
f3680f9
Adds a banner detailing our end-of-year pause in releases (#18975)
mrjoro Oct 26, 2018
3d9516d
Support WorkletAnimation only if amp-position-observer is present (#1…
nainar Oct 26, 2018
cb21e8b
Change Story Ad Insertion (#18959)
calebcordry Oct 26, 2018
bd134d3
✨Allow pubs to prevent ads in amp-story slots (#18946)
calebcordry Oct 26, 2018
e51e3a1
amp-analytics: allow use of iframe with inabox (#18653)
jeffkaufman Oct 26, 2018
71d973b
Adjust the scroll position to center highlighted texts if the right p…
yunabe Oct 26, 2018
9fdd872
Update the meta tag list of amp cache modifications. (#18966)
Gregable Oct 26, 2018
92da5e6
add a check that expected caches appear in caches.json (#18964)
honeybadgerdontcare Oct 26, 2018
5ea8432
🐛Fix navigateTo action when used in a viewer. (#18963)
Oct 26, 2018
a2df2ec
♻️ Render proxy form in AMP ⚡ (#18978)
alanorozco Oct 26, 2018
65379df
Launch amp-story-responsive-units experiment (#18989)
newmuis Oct 26, 2018
e2e8517
Add support for <noscript><picture><source>. (#18996)
Gregable Oct 26, 2018
d62d44b
Post message current page's script's URL to SW for caching (#18907)
prateekbh Oct 26, 2018
6849d93
Close `<image>` tags in the leaks.html test to resolve minor error (#…
Gregable Oct 26, 2018
08b21dd
Allow resuming a TimeAdvancement after being paused. (#19002)
gmajoulet Oct 26, 2018
589d3f1
Fixing audio UX message if there's a story level audio. (#18998)
gmajoulet Oct 26, 2018
fec8409
Update experiment for scroll-height-bounce to be "on" in canary and "…
Oct 26, 2018
1c83196
Proactively refresh overflow to avoid rendering bugs on iOS (#19007)
Oct 27, 2018
ed6d896
✨ Trigger docking actions from slot or video (#19005)
alanorozco Oct 27, 2018
0ac35a3
Launch scroll-height-bounce on PROD (#19013)
Oct 28, 2018
7c850c5
amp-subscriptions: Add viewer auth failure fallback (#18991)
Oct 29, 2018
8fd07f9
update docs (#18838)
alabiaga Oct 29, 2018
1a792c6
🐛 Doubleclick-Impl.js: Updates the logic in getPageParameters so that…
dmm9999 Oct 29, 2018
6ac4345
Validator rollup (#19010)
Gregable Oct 29, 2018
3409295
♻️ Render settings modal in AMP ⚡ (#18993)
alanorozco Oct 29, 2018
dcd136d
SwG release 0.1.22.35 (#19029)
Oct 29, 2018
90c8277
Add EPICA (#18832)
Oct 30, 2018
4811b1d
removed experimental flag from effects (#18979)
CrystalOnScript Oct 30, 2018
f95c722
Update package.json node version. Fixes PR builds. (#19046)
cvializ Oct 30, 2018
c51b4a6
✨ Add domLoadingTime to ad requests (#19001)
warrengm Oct 30, 2018
4512012
✨ Log custom analytics events in `amp-video-iframe` (#18869)
alanorozco Oct 30, 2018
df28cfb
🗑Remove old url replacement code (#18968)
calebcordry Oct 30, 2018
3a5c945
Fix/node version 2 (#19051)
cvializ Oct 30, 2018
299b0ab
Change crypto fallback message to user error (#18882)
lannka Oct 30, 2018
36fd394
✨ Add binding for amp-date-picker min attribute (#19035)
cvializ Oct 30, 2018
dd80243
[#18671], Fix a11y issue for IE platform (#19037)
sagarkbhatt Oct 30, 2018
a4edc73
✨amp-analytics: Add support for TEA Analytics (#18888)
Harx Oct 30, 2018
d8d0a49
Unlaunch scroll-height-bounce from PROD (#19055)
Oct 30, 2018
f3601ef
Unlaunch scroll-height-bounce from canary (#19056)
Oct 30, 2018
d5ec88b
Unlaunch amp-story-responsive-units for urgent release (#19057)
Oct 30, 2018
7bc1389
🐛Fixed Analytics Visible Trigger with the Intersection Observer Polyf…
torch2424 Oct 30, 2018
1803bf5
rename reportPlatformFailure to be more descriptive (#18994)
jpettitt Oct 31, 2018
ba7cd38
fix amp-date-picker and amp-viz-vega for single pass (#19031)
erwinmombay Oct 31, 2018
e041b39
🖍 Allow @page CSS at-rule (#17481)
westonruter Oct 31, 2018
44c68b7
✨Allow to pass amp-analytics config to CustomEventReporterBuilder (#1…
Oct 31, 2018
3a29c54
Subscriptions service public method to render the dialog with the cur…
gmajoulet Oct 31, 2018
b03b646
Amp subscriptions refactor (#19072)
jpettitt Oct 31, 2018
388dc38
Validator rollup (#19068)
twifkak Oct 31, 2018
be5d88c
[ANIMATION WORKLET] Change position observer detection logic in `amp-…
nainar Oct 31, 2018
c15ace5
🐛Fix `data-amp-replace` comparison logic (#19069)
calebcordry Oct 31, 2018
3901ea2
Fix docking overlay/shadow not being sized (#19077)
alanorozco Nov 1, 2018
725c8ce
📖 Update code documentation for IE11 A11Y fix #19064
sagarkbhatt Nov 1, 2018
60cc750
📖 amp-add-this: Update Example (#18961)
taojing10 Nov 1, 2018
af8801f
rollback #18871 (#19079)
Enriqe Nov 1, 2018
99684bf
Report when (#18847)
jonkeller Nov 1, 2018
e4da27a
🐛 placeholder in layout=container should not take space after hiding …
aghassemi Nov 1, 2018
d656b14
Better fixed-layer transferability comment (#19062)
Nov 1, 2018
4313dfb
✨ amp-3d-gltf: Add action to rotate model (#18873)
mixtur Nov 1, 2018
bd35089
Launch hold to pause experiment. (#19086)
gmajoulet Nov 1, 2018
97e446e
Introduce an experiment that requires body to have a minimum height i…
Nov 1, 2018
c73e143
Update Expressions section of amp-subscriptions doc (#18840)
Nov 1, 2018
0eebe60
Declare scroll-height-minheight at 0% in config (#19099)
Nov 1, 2018
8dcd184
fix documentation mistakes of amp-fx-collection (#19059)
PengXing Nov 2, 2018
d605aff
✨ amp-powr-player component (#19043)
chadladensack Nov 2, 2018
a0ca29d
✨ [amp-carousel] Add support for defined number of loops to autoplay …
nainar Nov 2, 2018
4634e1f
Explicitly document first viewport recommendation for subscriptions (…
Nov 2, 2018
9193471
📖 Improve consistency of AMP cache FQDN patterns (#19070)
davidstrauss Nov 2, 2018
fc5b05f
Render the bookend in its own <amp-story-bookend> tag. (#19110)
gmajoulet Nov 2, 2018
5d3689f
✨amp-recaptcha-input: Install recaptcha-service on the document, and …
torch2424 Nov 2, 2018
38f4c32
🏗 Update `make-extension` to use `this.element.ownerDocument` (#18260)
alanorozco Nov 2, 2018
d0b8376
fixing regexp (#19065)
prateekbh Nov 2, 2018
b2d14be
📖 Change the UK spelling of behaviour to US spelling behaviour (#18723)
Nov 2, 2018
29b1721
typo amp-subscriptions.md (#19116)
jpettitt Nov 2, 2018
67b5c0b
Do not validate for #development=1 when on AMP Caches (#19096)
honeybadgerdontcare Nov 2, 2018
1da4a11
Hide navigation hint when opening the bookend. (#19113)
gmajoulet Nov 2, 2018
1f3970c
Improve amp-analytics integration test coverage (#19118)
lannka Nov 2, 2018
7ac67a4
Switch to using sourceUrl instead of documentLocation (#19119)
zikas Nov 2, 2018
6ea2c37
Allow decoding on img tag. (#19122)
honeybadgerdontcare Nov 2, 2018
bb91ae7
[ANIMATION WORKLET] Calculate viewport-margins for scroll linked anim…
nainar Nov 3, 2018
7eaa1bd
Validator rollup (#19120)
twifkak Nov 3, 2018
0dfc8c9
Fix amp4test request-bank (#19123)
lannka Nov 3, 2018
289d46c
Support useBody config to send payload as POST body. (#19102)
lannka Nov 3, 2018
78e80f1
Remove non-string log messages (#18809)
cvializ Nov 5, 2018
d26327a
Re-launch amp-story-responsive-units experiment (#19140)
newmuis Nov 5, 2018
85bfea3
📖 🐛 Corrected the link to `hidden` global attribute (#19137)
xprt64 Nov 5, 2018
f303264
✨ amp- apester: support new player (#19131)
IdanLanger Nov 5, 2018
205377a
♻️ Add param to internal embed config (#19108)
Dannaz Nov 5, 2018
13f22d8
Fix p0 caused by hidden-mutation-observer experiment (#19141)
cvializ Nov 5, 2018
c61415d
✨Add new amp-skimlinks extension (#17907)
Nov 5, 2018
c2a16b4
♻️ Fixed issue with CLIENT_ID for pressboard analytics vendor (#19104)
omar84 Nov 5, 2018
a99c970
amp-analytics: Gemius dnt param (#16436)
k-krygiel Nov 5, 2018
1b35c6e
Add example for reportWhen usage (#19091)
jonkeller Nov 5, 2018
07d9cc1
Fix AMP cache viewer removing document element classes on iOS. (#19106)
felixarntz Nov 5, 2018
a6e6f43
Validator rollup (#19151)
twifkak Nov 5, 2018
465121b
Allow SVG 'focusable' attribute from SVG Tiny 1.2 (#19128)
westonruter Nov 6, 2018
dec1f26
Remove minimum-scale from required meta viewport properties (#19129)
westonruter Nov 6, 2018
af17a6a
swg 0.1.22.37 release (#19147)
jpettitt Nov 6, 2018
7f42093
[ANIMATION WORKLET ] Support `intersection-ratios` (#19145)
nainar Nov 6, 2018
9fe94a0
Ignore lightbox elements in FixedLayer (#19150)
jridgewell Nov 6, 2018
6607d59
♻️Expander: simplify arguments (#19152)
calebcordry Nov 6, 2018
4062362
Don't encode `ExpandStringAsync` (#19161)
calebcordry Nov 6, 2018
1c73173
ensure that startDate and endDate are preserved keys. these come from…
erwinmombay Nov 6, 2018
5bbe4f4
Re-enable hidden-mutation-observer. (#19163)
Nov 6, 2018
ba62048
Delete the amp-story-scroll experiment. (#19153)
gmajoulet Nov 6, 2018
3d74f57
amp-script: Worker debug hooks, use upgrade() API (#19006)
Nov 7, 2018
494222c
allow attribution and sizes on img within noscript (#19167)
honeybadgerdontcare Nov 7, 2018
e2a6aaf
🐛Don't auto opt in linker twice (#19103)
calebcordry Nov 7, 2018
ab5bd04
✨amp-recaptcha-input: Added checks to make sure we only allow a singl…
torch2424 Nov 7, 2018
c1d19f9
✨ Implements tooltip for amp-story (#18945)
Enriqe Nov 7, 2018
653fc41
Reset the UI once any action completes: delegated or non-delegated (#…
Nov 8, 2018
4bef1f1
✨ amp-subscriptions: Add logging to analytics events (#19173)
jpettitt Nov 8, 2018
b7dec00
Add message whitelist functionality to inabox messaging host (#18698)
zombifier Nov 8, 2018
98f33d9
Sync fixed-layer attributes with body (#19169)
jridgewell Nov 8, 2018
67f17dd
Introduce interactivity to visual diff tests (experimental) (#19114)
danielrozenberg Nov 8, 2018
332bded
✨Implement AMP AsyncInput Base Class for amp-recaptcha-input (#19115)
torch2424 Nov 8, 2018
a08da77
Fix HTML_ATTR (#19185)
lannka Nov 8, 2018
f87c69d
Update csa.md to remove beta language (#16315)
mmcao Nov 9, 2018
dcabeda
Remove text that is no longer needed (#19208)
jonkeller Nov 9, 2018
c43cdf5
Update amp-story-user-overridable.css (#19209)
newmuis Nov 9, 2018
c8063ab
amp-bind: Support alternative binding syntax with amp-list (#19204)
Nov 9, 2018
04982d0
Invalidate amp-script (#19214)
Nov 10, 2018
7704d82
🏗✨ Configure Renovate to allow all active LTS versions of node in pac…
rsimha Nov 10, 2018
ecedd63
Update dependency multer to v1.4.1 (#18690)
Nov 10, 2018
9389f9f
Update dependency @ampproject/worker-dom to v0.2.1 (#18717)
Nov 10, 2018
afe062b
Update dependency fetch-mock to v7.2.5 (#18763)
Nov 10, 2018
0deefc4
Update dependency autoprefixer to v9.3.1 (#18773)
Nov 10, 2018
b8345bc
Update dependency @octokit/rest to v15.16.1 (#18827)
Nov 10, 2018
0fae843
Update dependency karma to v3.1.1 (#18884)
Nov 10, 2018
3b49663
Update react monorepo to v16.6.1 (#18914)
Nov 10, 2018
1e51990
Update dependency eslint-plugin-eslint-plugin to v1.4.1 (#18951)
Nov 10, 2018
9de2d0d
Update dependency sinon to v7.1.1 (#18980)
Nov 10, 2018
4874cf2
Update dependency eslint to v5.8.0 (#19011)
Nov 10, 2018
20819ce
Update dependency typescript to v3.1.6 (#18694)
Nov 10, 2018
d486802
Viewer focus capability (#18783)
alabiaga Nov 10, 2018
13b8218
🐛Allow looking up AmpDoc when it might not be available. (#17804)
Nov 10, 2018
8169cbc
Introduce a method to update localstorage value (#19186)
zhouyx Nov 10, 2018
cea8c68
Update dependency through2 to v2.0.5 (#19239)
Nov 10, 2018
5518e63
amp-script: First-pass documentation (#19249)
Nov 12, 2018
36bedc6
Restrict the number of global replacements variable (#19233)
zhouyx Nov 12, 2018
b8445ff
🏗 Update node major version in `package.json` and `.travis.yml` to us…
rsimha Nov 12, 2018
f18f7eb
Only attach internal classNames to elements not in templates (#19260)
cvializ Nov 12, 2018
4b9bb00
🐛Expander: Don't double encode nested macros (#19164)
calebcordry Nov 12, 2018
661ee28
Fix placeholder to display none in resizable children (#19182)
cathyxz Nov 12, 2018
d823cc4
Add sandbox attributes to amp-video-iframe (#18228)
klipstein Nov 12, 2018
94aa2f7
🖍 🐛 Docking UX refinements (#19179)
alanorozco Nov 12, 2018
733bef6
🏗 Update allowed nodejs versions for validator (#19264)
rsimha Nov 12, 2018
fe4d169
✨ amp-delight-player (#17939)
Nov 12, 2018
9e175e7
SwG Release 0.1.22.38 (#19262)
Nov 12, 2018
2f1b827
✨amp-recaptcha-input: Origin Domain Verification within Bootstrap Fra…
torch2424 Nov 12, 2018
ab609a8
[amp-story] Allows inline json config for bookend and share providers…
Enriqe Nov 12, 2018
2c7b206
🏗 Rename `--skip` to `--empty` in `gulp visual-diff` (#19267)
danielrozenberg Nov 12, 2018
d8be323
✨Support object-fit transitions for amp-lightbox-gallery (#19175)
Nov 12, 2018
8b1c85e
add missing `-` (#19272)
erwinmombay Nov 12, 2018
a3e7a8b
Delete validator-amp-delight.player.out (#19273)
aghassemi Nov 13, 2018
0303c1f
Fixed typo in method JSDoc (#19268)
bramanudom Nov 13, 2018
e2b0aaa
Add .editorconfig (#18401)
westonruter Nov 13, 2018
998e3e0
♻️ amp-byside-content improvements (#18962)
bysidedevel3rdparty Nov 13, 2018
e5ff0af
📖 Update documentation regarding publicly accessibly Percy project (#…
danielrozenberg Nov 13, 2018
0ff4ba9
🐛Fix transition playing when closing from gallery view. (#19274)
Nov 13, 2018
6641165
Adds unit tests for tooltip ✅ (#19217)
Enriqe Nov 13, 2018
4929673
Validator rollup (#19294)
alin04 Nov 13, 2018
501a71a
Don't display tooltip when target is under cta layer 🐛 (#19287)
Enriqe Nov 13, 2018
0c7b46e
cl/221321313 n/a (#19300)
alin04 Nov 13, 2018
bb8dea7
Remove vsync guards to fx presets (#19197)
nainar Nov 13, 2018
0c5e783
Updated AMP Story ad documentation (#19174)
CrystalOnScript Nov 14, 2018
1c60929
Fix gestures recognizers end up in broken state after additional unac…
cathyxz Nov 14, 2018
641762f
Add comments (#19198)
jridgewell Nov 14, 2018
810575f
Ban DOM v4 methods (#19202)
jridgewell Nov 14, 2018
3244018
🐛Update cookie name from segment_amp_id to _ga (#19283)
Nov 14, 2018
c0bf92d
Render AMP fluid creatives when iframe fires load event (#19296)
glevitzky Nov 14, 2018
db0152a
Opt in into the desktop full bleed experience. (#19271)
gmajoulet Nov 14, 2018
dba4d64
Stories share menu redesign. (#19303)
gmajoulet Nov 14, 2018
2afad3b
Fix <amp-fx="fly-in-{left|right}"> for IE/Edge. (#19301)
nainar Nov 14, 2018
e3ac7f0
✨Converted amp-recaptcha-input into an AsyncInput Element (#19201)
torch2424 Nov 14, 2018
3ce0a38
Update iterateCursor (#19309)
jridgewell Nov 14, 2018
c386a4b
Stories desktop fullbleed bookend. (#19317)
gmajoulet Nov 14, 2018
bf18d20
Run an initial render in buildCallback (#19319)
cvializ Nov 14, 2018
bf11b71
✅Integration tests for amp-video-iframe (#19196)
alanorozco Nov 14, 2018
c1251c0
🐛 amp-analytics: allow intersectionRatio to be used on :root (#19280)
jeffkaufman Nov 14, 2018
75edc87
🏗 Add `--fortesting` to `gulp build` step in `pr-check.js` (#19316)
danielrozenberg Nov 14, 2018
b0d5940
🚮 Remove ad-like assertions from amp-video-iframe (#19323)
alanorozco Nov 14, 2018
0b68217
fix amp-ad support for Ad Generation (#18758)
adg-dev Nov 14, 2018
7412a07
🐛 Mute/unmute only if not managed by MediaPool (#19328)
alanorozco Nov 15, 2018
b245e40
🏗 Silence fake XHR server logs during automated tests (#19329)
rsimha Nov 15, 2018
20d473b
Various amp-selector clean up (#19216)
Nov 15, 2018
39c37ab
🐛story-ads: prevent users getting stuck (#19335)
calebcordry Nov 15, 2018
cc159fe
add more owners for extensions (#19299)
erwinmombay Nov 15, 2018
d53de19
Add smoothing. Add test (#19325)
nainar Nov 15, 2018
b6b8129
✨🏗 Upgrade Closure Compiler to v20180101 (#18794)
rsimha Nov 15, 2018
bc7cc68
Skip amp-video-iframe integration tests (#19342)
alanorozco Nov 15, 2018
7838f8c
Update dependency google-closure-compiler to v20181028 (#19244)
Nov 15, 2018
0969bd4
Update babel monorepo (#19306)
Nov 15, 2018
45163fb
Update react monorepo to v16.6.3 (#19307)
Nov 15, 2018
860e7dc
Update dependency through2 to v3 (#19246)
Nov 15, 2018
2b45ad4
Update dependency jsdom to v13 (#19245)
Nov 15, 2018
aa6da1a
Update dependency doctrine to v3 (#19243)
Nov 15, 2018
97859a1
Update dependency rollup to v0.67.1 (#19238)
Nov 15, 2018
8872678
Update dependency @ampproject/worker-dom to v0.2.2 (#19248)
Nov 15, 2018
d7fc907
🏗 `gulp visual-diff` refactor and stability fixes (#19327)
danielrozenberg Nov 15, 2018
d7e3d13
Synchronous Custom Elements Polyfill (#19305)
jridgewell Nov 15, 2018
38584c9
Update dependency tsickle to v0.33.1 (#19230)
Nov 15, 2018
0ae8417
Update dependency fs-extra to v7.0.1 (#19235)
Nov 15, 2018
798c95b
♻️ Fix string literal warnings in UI extensions (#19324)
cathyxz Nov 15, 2018
810cf84
pass single pass type to query params if it exists (#19076)
erwinmombay Nov 15, 2018
8386d95
Cleanup the amp-story-hold-to-pause experiment. (#19332)
gmajoulet Nov 15, 2018
48382c0
🐛 Fix thirds and fill layer in Safari (#19194)
Enriqe Nov 15, 2018
f3d8d40
📖story-ads: update docs (#19308)
calebcordry Nov 16, 2018
2a74533
🐛Intersection Observer Polyfill Mutation Observer - Fixed Race Condit…
torch2424 Nov 16, 2018
77173e2
Exclude build-system from the LGTM analysis (#19313)
xcorail Nov 16, 2018
33649b9
✨ anchor mutators on contextmenu event (navigation.js) (#19275)
Nov 16, 2018
9665b20
Change the background color of highlighted texts from yellow to orang…
yunabe Nov 16, 2018
7d69a49
Update third_party/closure-library/sha384-generated.js (#19356)
rsimha Nov 16, 2018
5083967
add owners to third_party (#19357)
erwinmombay Nov 16, 2018
c25ae36
Update dependency babel-plugin-filter-imports to v2.0.4 (#19242)
Nov 16, 2018
37aee2c
Update dependency @octokit/rest to v15.17.0 (#19241)
Nov 16, 2018
37030cc
✨ amp-next-page: Add support for type="adsense" (#18188)
peterjosling Nov 16, 2018
1a91b2b
♻️ AMP-Consent: Move config related code to its own file (#19311)
zhouyx Nov 16, 2018
a231088
add config owners (#19352)
erwinmombay Nov 16, 2018
5a9a107
✅ Add visual and interactive test for amp-story-tooltip (#19250)
Enriqe Nov 16, 2018
6b40744
Mark two visual diff tests as flaky (#19365)
danielrozenberg Nov 16, 2018
1a3b149
FIE support for <amp-gwd-animation> (#19355)
sklobovskaya Nov 16, 2018
34cbfc7
Squash pagination buttons for fullbleed desktop commits. (#19315)
gmajoulet Nov 16, 2018
766ac03
Fix dynamic extension path (#19340)
erwinmombay Nov 16, 2018
fbbd44e
🐛 Trick Closure compiler to preserve reflow codepath (#19367)
alanorozco Nov 16, 2018
2b83339
Move Percy installation to visual-diff task (#19341)
estherkim Nov 16, 2018
67544be
✨ Add type adyoulike for the amp-ad tag (#18983)
j343my Nov 17, 2018
7731c43
Uninstall positionObserver when using WorkletAnimation (#19348)
nainar Nov 18, 2018
730a6fc
🐛 Replace CDN URLs in video testbench (#19373)
alanorozco Nov 19, 2018
048b021
Update link to JWT token generation documentation (#19339)
trodrigues Nov 19, 2018
df2c319
add amp-story-tooltip anchor tags validation ✅ (#19285)
Enriqe Nov 19, 2018
e43a3c9
🐛Linker: check for empty param values (#19369)
calebcordry Nov 19, 2018
ab873eb
🐛Linker: remove undefined warning string (#19353)
calebcordry Nov 19, 2018
f5dda00
Add typedefs for pool-bound and placeholder elements (#19368)
newmuis Nov 19, 2018
1a7213c
🐛 amp-subscriptions platform reset all platforms on reauthorise (#19384)
jpettitt Nov 19, 2018
73cb446
Modify the error handling of visual diff tests to be more robust (#19…
danielrozenberg Nov 19, 2018
395c68c
✨ amp-brid-player: Dynamic playlist support (#19190)
pedjoni8 Nov 19, 2018
b972676
allow hidden with repeat (#19363)
zhouyx Nov 19, 2018
d76182a
Disable flaky tests (#19390)
newmuis Nov 19, 2018
6b09d02
🐛 amp-ima-video: Show sound and fullscreen buttons during ads (#18954)
curseagain Nov 20, 2018
d2d103e
amp-add-this: Add CSS for Addthis floating tool (#19382)
taojing10 Nov 20, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
20 changes: 0 additions & 20 deletions .babelrc

This file was deleted.

32 changes: 32 additions & 0 deletions .codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Settings for https://codecov.io integration

# See https://docs.codecov.io/docs/pull-request-comments
comment: off

# See https://docs.codecov.io/v4.3.0/docs/commit-status
coverage:
status:
project:
default: off
unit_tests:
flags: unit_tests
target: auto
threshold: 100 # Passing check no matter what the coverage is
base: auto
integration_tests:
flags: integration_tests
target: auto
threshold: 100 # Passing check no matter what the coverage is
base: auto
patch:
default: off
unit_tests:
flags: unit_tests
target: 100 # Target 100% coverage for diffs
threshold: 100 # Passing check no matter what the coverage is
base: auto
integration_tests:
flags: integration_tests
target: 100 # Target 100% coverage for diffs
threshold: 100 # Passing check no matter what the coverage is
base: auto
12 changes: 12 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
root = true

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
indent_style = space
indent_size = 2

[{*.md}]
trim_trailing_whitespace = false
25 changes: 25 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
node_modules
build
build-system/tasks/visual-diff/snippets/*.js
build-system/babel-plugins/**/fixtures/**/*.js
build-system/app-index/test/**/*.js
dist
dist.3p
dist.tools
out
examples
third_party
test/coverage
**/*.extern.js
validator/dist
validator/webui/dist
validator/node_modules
validator/nodejs/node_modules
validator/webui/node_modules
eslint-rules
karma.conf.js
testing/local-amp-chrome-extension
extensions/amp-a4a/0.1/test/testdata
extensions/amp-access/0.1/access-expr-impl.js
extensions/amp-animation/0.1/css-expr-impl.js
extensions/amp-bind/0.1/bind-expr-impl.js
168 changes: 150 additions & 18 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,39 +1,114 @@
{
"root": true,
"parser": "babel-eslint",
"ecmaFeatures": {
"modules": true,
"arrowFunctions": true,
"blockBindings": true,
"forOf": false,
"destructuring": false,
"spread": false
},
"plugins": [
"chai-expect",
"eslint-plugin-amphtml-internal",
"eslint-plugin-google-camelcase",
"jsdoc",
"sort-imports-es6-autofix",
"sort-requires"
],
"env": {
"es6": true,
"browser": true
},
"parserOptions": {
"ecmaVersion": 6,
"sourceType": "module"
},
"globals": {
"AMP": false,
"context": false,
"global": false
},
"settings": {
"jsdoc": {
"tagNamePreference": {
"returns": "return",
"constant": "const",
"class": "constructor"
},
"additionalTagNames": {
"customTags": [
"deprecated",
"export",
"final",
"package",
"restricted",
"suppress",
"template",
"visibleForTesting"
]
},
"allowOverrideWithoutParam" : true
}
},
"rules": {
"amphtml-internal/closure-type-primitives": 2,
"amphtml-internal/dict-string-keys": 2,
"amphtml-internal/enforce-private-props": 2,
"amphtml-internal/html-template": 2,
"amphtml-internal/is-experiment-on": 2,
"amphtml-internal/no-array-destructuring": 2,
"amphtml-internal/no-deep-destructuring": 2,
"amphtml-internal/no-duplicate-import": 2,
"amphtml-internal/no-es2015-number-props": 2,
"amphtml-internal/no-export-side-effect": 2,
"amphtml-internal/no-for-of-statement": 2,
"amphtml-internal/no-global": 0,
"amphtml-internal/no-has-own-property-method": 1,
"amphtml-internal/no-import": 2,
"amphtml-internal/no-import-rename": 2,
"amphtml-internal/no-is-amp-alt": 2,
"amphtml-internal/no-mixed-operators": 2,
"amphtml-internal/no-non-string-log-args": 1,
"amphtml-internal/no-spread": 2,
"amphtml-internal/no-style-display": 2,
"amphtml-internal/no-style-property-setting": 2,
"amphtml-internal/no-swallow-return-from-allow-console-error": 2,
"amphtml-internal/prefer-deferred-promise": 1,
"amphtml-internal/prefer-destructuring": 2,
"amphtml-internal/query-selector": 2,
"amphtml-internal/todo-format": 0,
"amphtml-internal/unused-private-field": 1,
"amphtml-internal/vsync": 1,
"array-bracket-spacing": [2, "never"],
"arrow-parens": [2, "as-needed"],
"arrow-spacing": 2,
"chai-expect/missing-assertion": 2,
"chai-expect/no-inner-compare": 2,
"chai-expect/terminating-properties": 2,
"comma-dangle": [2, "always-multiline"],
"computed-property-spacing": [2, "never"],
"curly": 2,
"dot-location": [2, "property"],
"eol-last": 2,
"google-camelcase/google-camelcase": 2,
"indent": [2, 2, { "SwitchCase": 1 }],
"indent": [2, 2, { "SwitchCase": 1, "VariableDeclarator": 2, "MemberExpression": 2, "ObjectExpression": 1, "CallExpression": { "arguments": 2 } }],
"jsdoc/check-param-names": 2,
"jsdoc/check-tag-names": 2,
"jsdoc/check-types": 2,
"jsdoc/require-param": 2,
"jsdoc/require-param-name": 2,
"jsdoc/require-param-type": 2,
"jsdoc/require-returns-type": 2,
"key-spacing": 2,
"max-len": [2, 80, 4, {
"ignoreComments": true,
"ignoreUrls": true,
"ignorePattern": ""
"ignoreTrailingComments": true,
"ignoreRegExpLiterals": true,
"ignorePattern": "^} from.*;|= require\\(.*;$|@typedef|@param|@return|@private|@const|@type|@implements",
"ignoreUrls": true
}],
"no-alert": 2,
"no-cond-assign": 2,
"no-debugger": 2,
"no-div-regex": 2,
"no-dupe-keys": 2,
"no-eval": 2,
"no-extend-native": 2,
"no-extra-bind": 2,
"no-extra-semi": 2,
"no-implicit-coercion": [2, { "boolean": false }],
"no-implied-eval": 2,
"no-iterator": 2,
Expand All @@ -49,28 +124,85 @@
"no-trailing-spaces": 2,
"no-unused-expressions": 0,
"no-unused-vars": [2, {
"argsIgnorePattern": "^var_|opt_|unused",
"varsIgnorePattern": "AmpElement|Def|Interface$"
"argsIgnorePattern": "^(var_args$|opt_|unused)",
"varsIgnorePattern": "(AmpElement|Def|Interface)$"
}],
"no-useless-call": 2,
"no-useless-concat": 2,
"no-undef": 2,
"no-var": 2,
"no-warning-comments": [2, { "terms": ["do not submit"], "location": "anywhere" }],
"object-curly-spacing": [2, "never", {
"objectsInObjects": false,
"arraysInObjects": false
}],
"object-shorthand": [2, "properties", { "avoidQuotes": true }],
"prefer-const": 2,
"quotes": [2, "single", "avoid-escape"],
"radix": 2,
"require-jsdoc": [2, {
"require": {
"FunctionDeclaration": true,
"MethodDefinition": true,
"ClassDeclaration": false,
"ArrowFunctionExpression": false,
"FunctionExpression": false
}
}],
"semi": 2,
"space-after-keywords": 2,
"keyword-spacing": [2, { "before": true, "after": true }],
"sort-imports-es6-autofix/sort-imports-es6": [2, {
"ignoreCase": false,
"ignoreMemberSort": false,
"memberSyntaxSortOrder": ["none", "all", "multiple", "single"]
}],
"sort-requires/sort-requires": 2,
"space-before-blocks": 2,
"space-before-function-paren": [2, "never"],
"space-before-keywords": 2,
"space-in-parens": 2,
"space-infix-ops": 2,
"space-unary-ops": [1, { "words": true, "nonwords": false }],
"space-return-throw-case": 2,
"wrap-iife": [2, "any"]
}
},
"overrides": [
{
"files": ["test/**/*.js", "extensions/**/test/**/*.js", "ads/**/test/**/*.js", "testing/**/*.js"],
"rules": {
"require-jsdoc": 0,
"jsdoc/check-param-names": 0,
"jsdoc/check-tag-names": 0,
"jsdoc/check-types": 0,
"jsdoc/require-param": 0,
"jsdoc/require-param-name": 0,
"jsdoc/require-param-type": 0,
"jsdoc/require-returns-type": 0
},
"globals": {
"it": false,
"chai": false,
"expect": false,
"describe": false,
"beforeEach": false,
"afterEach": false,
"before": false,
"after": false,
"assert": false,
"sinon": true,
"sandbox": true,
"describes": true,
"allowConsoleError": false,
"expectAsyncConsoleError": false,
"restoreAsyncErrorThrows": false,
"stubAsyncErrorThrows": false
}
},
{
"files": ["babel.config.js"],
"globals": {
"module": false,
"process": false,
"require": false
}
}
]
}
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
**Please only file bugs/feature requests for AMP here.**

- If you have questions about how to use AMP or other general questions about AMP please ask them on Stack Overflow under the AMP HTML tag instead of filing an issue here: http://stackoverflow.com/questions/tagged/amp-html
- If you have questions/issues related to Google Search please ask them in Google's AMP forum instead of filing an issue here: https://goo.gl/utQ1KZ

If you have a bug or feature request for AMP please fill in the following template. Delete everything except the headers (including this text).

## What's the issue?

Briefly describe the bug/feature request.

## How do we reproduce the issue?

If this is a bug please provide a public URL and ideally a reduced test case (e.g. on jsbin.com) that exhibits only your issue and nothing else. Then provide step-by-step instructions for reproducing the issue:

1. Step 1 to reproduce
2. Step 2 to reproduce
3. …

If this is a feature request you can use this section to point to a prototype/mockup that will help us understand the request.

## What browsers are affected?

All browsers? Some specific browser? What device type?

## Which AMP version is affected?

Is this a new issue? Or was it always broken? Paste your AMP version. You can find it in the browser dev tools.
33 changes: 33 additions & 0 deletions .github/ISSUE_TEMPLATE/cherry_pick_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
**Replace *everything* in angle brackets in the title AND body of this issue. If you have any questions see the [cherry pick documentation](https://github.com/ampproject/amphtml/blob/master/contributing/release-schedule.md#cherry-picks).**


**GitHub issue your cherry pick is fixing:**

Issue #<ISSUE_NUMBER>


**PR that you are requesting a cherry pick for:**

*(Put N/A if you do not yet have a PR with a fix; edit this issue to add it when the PR is ready.)*

PR #<PR_NUMBER>


**Release(s) you requesting this cherry pick into:**

*Release issues can be found at https://github.com/ampproject/amphtml/labels/Type%3A%20Release*

*If you are requesting a cherry pick into a production release you will most likely need to cherry pick into canary as well, otherwise when the canary is pushed to production your fix will be lost. See the [cherry pick documentation](https://github.com/ampproject/amphtml/blob/master/contributing/release-schedule.md#cherry-picks).)*

Production Release? <YES/NO> If yes, Type: Release Issue #<PRODUCTION_RELEASE_ISSUE>

Canary release? <YES/NO> If yes, Type: Release Issue #<CANARY_RELEASE_ISSUE>, otherwise <WHY_THIS_IS_NOT_NEEDED>


*Why does this issue meet the [cherry pick criteria](https://github.com/ampproject/amphtml/blob/master/contributing/release-schedule.md#cherry-pick-criteria)? Be specific.*

<YOUR_REASONS>

*Assign this issue to the current TL (cramforce) if you have permission to, otherwise leave this cc line in.*

/cc @cramforce
Loading