Merged from ampproject/master

.codecov.yml

@@ -0,0 +1,32 @@
+# Settings for https://codecov.io integration
+
+# See https://docs.codecov.io/docs/pull-request-comments
+comment: off
+
+# See https://docs.codecov.io/v4.3.0/docs/commit-status
+coverage:
+  status:
+    project:
+      default: off
+      unit_tests:
+        flags: unit_tests
+        target: auto
+        threshold: 100 # Passing check no matter what the coverage is
+        base: auto
+      integration_tests:
+        flags: integration_tests
+        target: auto
+        threshold: 100 # Passing check no matter what the coverage is
+        base: auto
+    patch:
+      default: off
+      unit_tests:
+        flags: unit_tests
+        target: 100 # Target 100% coverage for diffs
+        threshold: 100 # Passing check no matter what the coverage is
+        base: auto
+      integration_tests:
+        flags: integration_tests
+        target: 100 # Target 100% coverage for diffs
+        threshold: 100 # Passing check no matter what the coverage is
+        base: auto

.editorconfig

@@ -0,0 +1,12 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true
+indent_style = space
+indent_size = 2
+
+[{*.md}]
+trim_trailing_whitespace = false

.eslintignore

@@ -0,0 +1,25 @@
+node_modules
+build
+build-system/tasks/visual-diff/snippets/*.js
+build-system/babel-plugins/**/fixtures/**/*.js
+build-system/app-index/test/**/*.js
+dist
+dist.3p
+dist.tools
+out
+examples
+third_party
+test/coverage
+**/*.extern.js
+validator/dist
+validator/webui/dist
+validator/node_modules
+validator/nodejs/node_modules
+validator/webui/node_modules
+eslint-rules
+karma.conf.js
+testing/local-amp-chrome-extension
+extensions/amp-a4a/0.1/test/testdata
+extensions/amp-access/0.1/access-expr-impl.js
+extensions/amp-animation/0.1/css-expr-impl.js
+extensions/amp-bind/0.1/bind-expr-impl.js

.eslintrc

@@ -1,39 +1,114 @@
 {
+  "root": true,
   "parser": "babel-eslint",
-  "ecmaFeatures": {
-    "modules": true,
-    "arrowFunctions": true,
-    "blockBindings": true,
-    "forOf": false,
-    "destructuring": false,
-    "spread": false
-  },
+  "plugins": [
+    "chai-expect",
+    "eslint-plugin-amphtml-internal",
+    "eslint-plugin-google-camelcase",
+    "jsdoc",
+    "sort-imports-es6-autofix",
+    "sort-requires"
+  ],
   "env": {
     "es6": true,
     "browser": true
   },
+ "parserOptions": {
+    "ecmaVersion": 6,
+    "sourceType": "module"
+  },
+  "globals": {
+    "AMP": false,
+    "context": false,
+    "global": false
+  },
+  "settings": {
+    "jsdoc": {
+      "tagNamePreference": {
+        "returns": "return",
+        "constant": "const",
+        "class": "constructor"
+      },
+      "additionalTagNames": {
+        "customTags": [
+          "deprecated",
+          "export",
+          "final",
+          "package",
+          "restricted",
+          "suppress",
+          "template",
+          "visibleForTesting"
+        ]
+      },
+      "allowOverrideWithoutParam" : true
+    }
+  },
   "rules": {
+    "amphtml-internal/closure-type-primitives": 2,
+    "amphtml-internal/dict-string-keys": 2,
+    "amphtml-internal/enforce-private-props": 2,
+    "amphtml-internal/html-template": 2,
+    "amphtml-internal/is-experiment-on": 2,
+    "amphtml-internal/no-array-destructuring": 2,
+    "amphtml-internal/no-deep-destructuring": 2,
+    "amphtml-internal/no-duplicate-import": 2,
+    "amphtml-internal/no-es2015-number-props": 2,
+    "amphtml-internal/no-export-side-effect": 2,
+    "amphtml-internal/no-for-of-statement": 2,
+    "amphtml-internal/no-global": 0,
+    "amphtml-internal/no-has-own-property-method": 1,
+    "amphtml-internal/no-import": 2,
+    "amphtml-internal/no-import-rename": 2,
+    "amphtml-internal/no-is-amp-alt": 2,
+    "amphtml-internal/no-mixed-operators": 2,
+    "amphtml-internal/no-non-string-log-args": 1,
+    "amphtml-internal/no-spread": 2,
+    "amphtml-internal/no-style-display": 2,
+    "amphtml-internal/no-style-property-setting": 2,
+    "amphtml-internal/no-swallow-return-from-allow-console-error": 2,
+    "amphtml-internal/prefer-deferred-promise": 1,
+    "amphtml-internal/prefer-destructuring": 2,
+    "amphtml-internal/query-selector": 2,
+    "amphtml-internal/todo-format": 0,
+    "amphtml-internal/unused-private-field": 1,
+    "amphtml-internal/vsync": 1,
     "array-bracket-spacing": [2, "never"],
     "arrow-parens": [2, "as-needed"],
     "arrow-spacing": 2,
+    "chai-expect/missing-assertion": 2,
+    "chai-expect/no-inner-compare": 2,
+    "chai-expect/terminating-properties": 2,
+    "comma-dangle": [2, "always-multiline"],
     "computed-property-spacing": [2, "never"],
     "curly": 2,
     "dot-location": [2, "property"],
     "eol-last": 2,
     "google-camelcase/google-camelcase": 2,
-    "indent": [2, 2, { "SwitchCase": 1 }],
+    "indent": [2, 2, { "SwitchCase": 1, "VariableDeclarator": 2, "MemberExpression": 2, "ObjectExpression": 1, "CallExpression": { "arguments": 2 } }],
+    "jsdoc/check-param-names": 2,
+    "jsdoc/check-tag-names": 2,
+    "jsdoc/check-types": 2,
+    "jsdoc/require-param": 2,
+    "jsdoc/require-param-name": 2,
+    "jsdoc/require-param-type": 2,
+    "jsdoc/require-returns-type": 2,
     "key-spacing": 2,
     "max-len": [2, 80, 4, {
-      "ignoreComments": true,
-      "ignoreUrls": true,
-      "ignorePattern": ""
+      "ignoreTrailingComments": true,
+      "ignoreRegExpLiterals": true,
+      "ignorePattern": "^} from.*;|= require\\(.*;$|@typedef|@param|@return|@private|@const|@type|@implements",
+      "ignoreUrls": true
     }],
     "no-alert": 2,
+    "no-cond-assign": 2,
     "no-debugger": 2,
     "no-div-regex": 2,
+    "no-dupe-keys": 2,
     "no-eval": 2,
     "no-extend-native": 2,
     "no-extra-bind": 2,
+    "no-extra-semi": 2,
     "no-implicit-coercion": [2, { "boolean": false }],
     "no-implied-eval": 2,
     "no-iterator": 2,
@@ -49,28 +124,85 @@
     "no-trailing-spaces": 2,
     "no-unused-expressions": 0,
     "no-unused-vars": [2, {
-      "argsIgnorePattern": "^var_|opt_|unused",
-      "varsIgnorePattern": "AmpElement|Def|Interface$"
+      "argsIgnorePattern": "^(var_args$|opt_|unused)",
+      "varsIgnorePattern": "(AmpElement|Def|Interface)$"
     }],
     "no-useless-call": 2,
     "no-useless-concat": 2,
+    "no-undef": 2,
     "no-var": 2,
     "no-warning-comments": [2, { "terms": ["do not submit"], "location": "anywhere" }],
     "object-curly-spacing": [2, "never", {
       "objectsInObjects": false,
       "arraysInObjects": false
     }],
+    "object-shorthand": [2, "properties", { "avoidQuotes": true }],
     "prefer-const": 2,
+    "quotes": [2, "single", "avoid-escape"],
     "radix": 2,
+    "require-jsdoc": [2, {
+      "require": {
+        "FunctionDeclaration": true,
+        "MethodDefinition": true,
+        "ClassDeclaration": false,
+        "ArrowFunctionExpression": false,
+        "FunctionExpression": false
+      }
+    }],
     "semi": 2,
-    "space-after-keywords": 2,
+    "keyword-spacing": [2, { "before": true, "after": true }],
+    "sort-imports-es6-autofix/sort-imports-es6": [2, {
+      "ignoreCase": false,
+      "ignoreMemberSort": false,
+      "memberSyntaxSortOrder": ["none", "all", "multiple", "single"]
+    }],
+    "sort-requires/sort-requires": 2,
     "space-before-blocks": 2,
     "space-before-function-paren": [2, "never"],
-    "space-before-keywords": 2,
     "space-in-parens": 2,
     "space-infix-ops": 2,
     "space-unary-ops": [1, { "words": true, "nonwords": false }],
-    "space-return-throw-case": 2,
     "wrap-iife": [2, "any"]
-  }
+  },
+  "overrides": [
+    {
+      "files": ["test/**/*.js", "extensions/**/test/**/*.js", "ads/**/test/**/*.js", "testing/**/*.js"],
+      "rules": {
+        "require-jsdoc": 0,
+        "jsdoc/check-param-names": 0,
+        "jsdoc/check-tag-names": 0,
+        "jsdoc/check-types": 0,
+        "jsdoc/require-param": 0,
+        "jsdoc/require-param-name": 0,
+        "jsdoc/require-param-type": 0,
+        "jsdoc/require-returns-type": 0
+      },
+      "globals": {
+        "it": false,
+        "chai": false,
+        "expect": false,
+        "describe": false,
+        "beforeEach": false,
+        "afterEach": false,
+        "before": false,
+        "after": false,
+        "assert": false,
+        "sinon": true,
+        "sandbox": true,
+        "describes": true,
+        "allowConsoleError": false,
+        "expectAsyncConsoleError": false,
+        "restoreAsyncErrorThrows": false,
+        "stubAsyncErrorThrows": false
+      }
+    },
+    {
+      "files": ["babel.config.js"],
+      "globals": {
+        "module": false,
+        "process": false,
+        "require": false
+      }
+    }
+  ]
 }

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,28 @@
+**Please only file bugs/feature requests for AMP here.**
+
+- If you have questions about how to use AMP or other general questions about AMP please ask them on Stack Overflow under the AMP HTML tag instead of filing an issue here: http://stackoverflow.com/questions/tagged/amp-html
+- If you have questions/issues related to Google Search please ask them in Google's AMP forum instead of filing an issue here: https://goo.gl/utQ1KZ
+
+If you have a bug or feature request for AMP please fill in the following template.  Delete everything except the headers (including this text).
+
+## What's the issue?
+
+Briefly describe the bug/feature request.
+
+## How do we reproduce the issue?
+
+If this is a bug please provide a public URL and ideally a reduced test case (e.g. on jsbin.com) that exhibits only your issue and nothing else.  Then provide step-by-step instructions for reproducing the issue:
+
+1. Step 1 to reproduce
+2. Step 2 to reproduce
+3. …
+
+If this is a feature request you can use this section to point to a prototype/mockup that will help us understand the request.
+
+## What browsers are affected?
+
+All browsers? Some specific browser? What device type?
+
+## Which AMP version is affected?
+
+Is this a new issue? Or was it always broken? Paste your AMP version. You can find it in the browser dev tools.

.github/ISSUE_TEMPLATE/cherry_pick_template.md

@@ -0,0 +1,33 @@
+**Replace *everything* in angle brackets in the title AND body of this issue.  If you have any questions see the [cherry pick documentation](https://github.com/ampproject/amphtml/blob/master/contributing/release-schedule.md#cherry-picks).**
+
+
+**GitHub issue your cherry pick is fixing:**
+
+Issue #<ISSUE_NUMBER>
+
+
+**PR that you are requesting a cherry pick for:**
+
+*(Put N/A if you do not yet have a PR with a fix; edit this issue to add it when the PR is ready.)*
+
+PR #<PR_NUMBER>
+
+
+**Release(s) you requesting this cherry pick into:**
+
+*Release issues can be found at https://github.com/ampproject/amphtml/labels/Type%3A%20Release*
+
+*If you are requesting a cherry pick into a production release you will most likely need to cherry pick into canary as well, otherwise when the canary is pushed to production your fix will be lost.  See the [cherry pick documentation](https://github.com/ampproject/amphtml/blob/master/contributing/release-schedule.md#cherry-picks).)*
+
+Production Release? <YES/NO>  If yes, Type: Release Issue #<PRODUCTION_RELEASE_ISSUE>
+
+Canary release? <YES/NO>  If yes, Type: Release Issue #<CANARY_RELEASE_ISSUE>, otherwise <WHY_THIS_IS_NOT_NEEDED>
+
+
+*Why does this issue meet the [cherry pick criteria](https://github.com/ampproject/amphtml/blob/master/contributing/release-schedule.md#cherry-pick-criteria)?  Be specific.*
+
+<YOUR_REASONS>
+
+*Assign this issue to the current TL (cramforce) if you have permission to, otherwise leave this cc line in.*
+
+/cc @cramforce