fix(*): compile binaries for mac and linux #16
Conversation
stepancar
changed the title
|
Why did the yarn.lock file change so much even though the package.json is pretty much the same? |
sabjorn
left a comment
sabjorn
left a comment
There was a problem hiding this comment.
LGTM -- one suggestion and one question but merge whenever you want
I didn't update yarn lock in the previous PR |
.github/workflows/prebuild.yml
Outdated
| run: node install_ffmpeg_static.js | ||
|
|
||
| - name: Build for npm publish | ||
| run: FFMPEG_STATIC=1 npx node-gyp rebuild |
There was a problem hiding this comment.
are builds platform specific? like if we build in the github action here, will the binary be able to be used on mac arm?
There was a problem hiding this comment.
@michaeljherrmann builds are platform specific, this is why I build for mac arm64 and linux64. For other environments installation fallback will rebuild package for current platform
There was a problem hiding this comment.
I just didn't see any code specific to arm here but maybe I missed it
|
|
||
| on: | ||
| push: | ||
| branches: [main] |
There was a problem hiding this comment.
if you remove the branch filter but keep push, doesn't this mean it will run on each push on each branch? do we want that?
There was a problem hiding this comment.
@michaeljherrmann ,
for regular pushes to branch it will just build binaries, which validates that change in PR valid
for merges to master it will release
Co-authored-by: Steeve Bjornson <stevenbjornson@gmail.com>
Use prebuild binaries for faster package installation