Get browser names, get device types, get OS names, get OS platform names functions#85
Open
trymeouteh wants to merge 3 commits intoLumenResearch:masterfrom
Open
Get browser names, get device types, get OS names, get OS platform names functions#85trymeouteh wants to merge 3 commits intoLumenResearch:masterfrom
trymeouteh wants to merge 3 commits intoLumenResearch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds simple functions that will return all of the valid names for browser names, device types, OS names and OS platform types.
This will be a useful addition to help developers easily get all the valid names as such functions exist in other user agent packages in other programming languages.
It should be added in the documentation that these functions will need to be updated if new names are added to the package.