Ewerk multilingual configuration#20
Open
falk-huth-ewerk wants to merge 5 commits intoM-Files:masterfrom
Open
Conversation
Updated UIX applications to support fast browsing.
…jects were not find from the originally checked in directory
…t as proof of concept
CraigHawker
requested changes
Oct 18, 2021
Collaborator
CraigHawker
left a comment
CraigHawker
left a comment
There was a problem hiding this comment.
Hi Falk,
Thank you for submitting this. A few quick items that need to be looked at before I can merge this:
- This seems to also include a (blank?) project named "SyncActiveDirectory". This needs to be removed.
- I don't think the local nuget.config file is needed.
- I think the multilingual project should be added to the other sln file, not have its own.
- I am aware that the other applications need updating to the latest 2.3 release (2.3.623.2) but if you could update this one as part of the submission then that saves me doing it.
Other than that it looks good at first glance. I'll try and take a better look at it later today, but thank you for the submission!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just created a sample with a multi-lingual configuration based on VAF 2.3 template