Issue 145 - Add Variable Day of Month Option for DayOfMonthTrigger#146
Open
william-deeken wants to merge 5 commits intoM-Files:masterfrom
Open
Issue 145 - Add Variable Day of Month Option for DayOfMonthTrigger#146william-deeken wants to merge 5 commits intoM-Files:masterfrom
william-deeken wants to merge 5 commits intoM-Files:masterfrom
Conversation
…ew variable monthly date.
… null if nthweekday param is invalid. Began writing tests.
…leDate test cases. To Do: Add GetNextExecution test cases.
…ype. Tests complete.
…iggerDays setting - updated ShowWhen for backwards compatibility. 3) ToString - updated to provide string representation for variabledate triggers. Schedule - 1) Refactored Triggers_DayOfMonthTrigger to Triggers_DayOfMonthTrigger_SpecificDate, updated fr/fi localized .resxs. 2) Added Triggers_DayOfMonthTrigger_VariableDate string.
Author
|
Has there been any progress on reviewing this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull has the following updates:
I've attached a spreadsheet with all the test cases I came up with:
VariableDate_TestCases.xlsx