Skip to content

Conversation

@hrodmn
Copy link
Contributor

@hrodmn hrodmn commented Dec 10, 2025

This one is short but will be a good resource for anyone who wants to query the HLS STAC Geoparquet Archive.

@hrodmn hrodmn self-assigned this Dec 10, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hrodmn
Copy link
Contributor Author

hrodmn commented Dec 15, 2025

@wildintellect or @smk0033 if you could review this PR sometime this week that would be great!

@hrodmn hrodmn requested review from jjfrench and removed request for smk0033 and wildintellect December 15, 2025 20:20
@@ -0,0 +1,238 @@
{
Copy link
Member

@jjfrench jjfrench Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we format this to include an author, date, and description?

Do we also need to separate some of the information into a "Run This Notebook" section? Could move the information about permissions into a disclaimer that it's recommended to be run within a MAAP Hub


Reply via ReviewNB

@@ -0,0 +1,238 @@
{
Copy link
Member

@jjfrench jjfrench Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this into an "Importing Packages" and "Searching the Data Store" sections?


Reply via ReviewNB

@@ -0,0 +1,238 @@
{
Copy link
Member

@jjfrench jjfrench Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# on the MAAP ADE
# client.execute(
#     f"""
#     CREATE OR REPLACE SECRET secret (
#         TYPE S3,
#         PROVIDER credential_chain
#     );
#     """
# )

Should this be the default code uncommented or do you want to switch which branch it's being merged to be maap-hub-docs?


Reply via ReviewNB

@@ -0,0 +1,238 @@
{
Copy link
Member

@jjfrench jjfrench Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then to read the file directly from S3 you need to request S3 credentials for the LPDAAC bucket and provide thsoe to rasterio via AWSSession:

typo *those

[Suggestion]

To read and visualize the file directly from S3, you need to request S3 credentials for the LPDAAC bucket and provide those to rasterio via AWSSession:


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants