Upstream TorchSim model interface #277
Draft
+459
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, we think ts is getting to a fairly mature point now and we would like to encourge what we have called external model posture similar to ase (TorchSim/torch-sim#120) I have made this PR as a basic demo of what an external implementation might look like for SevenNet TorchSim/torch-sim#429.
I made some basic changes to the CI to add linting and using uv for test env such that ts will resolve properly for > py312 whilst still pointing to the external model PR. Draft until that PR get's merged/0.5.2 release.