Open
Conversation
added 12 commits
May 26, 2022 22:02
…ed on tab selection change
…eeded by FeatureService
…r already changing GUI tabs
…already changing GUI tabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon #12 gui state
Main Functionality
Add ability to bandbox select features. The new feature bandbox selection should be free-form and not snap to the grid.
Notable Side Effects
This PR adds a static reference to a FeatureService to the FeatureInstance class. It seems baffling that a FeatureInstance cannot tell what feature it is. There may be a good reason for the ommision, it seems that TA features may only have a name to identify themselves and this is a carry over from the domain that Mappy models (possibly not though?).
Bugfix
An attempt was made to fix/workaround the BatchMoveFeatureOperation bug. The bug assumes that the destination of any feature does not contain another feature that is also about to be moved.
Functional Requirements: