EQDSK methods #493
Draft
EQDSK methods #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
let's talk at next week's meeting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional methods for retrieving EFIT parameters to reconstruct a GEQDSKFile from the FreeQDSK library.
It also adds a new timebase option
uniform_1kHzwhich is what I have been using for my POPSIM work across C-Mod, DIII-D, and TCV.The one concern I have is regarding interpolation. If the requested timebase does not line up with EFIT, the data vars for limiter/boundary points stop meaning anything because the number of points can change between timesteps. This is an edge case I haven't given much thought to since I don't use these vars in any of my workflows, but it should probably be handled gracefully. Open to suggestions on how to address this.