Revive D3D get_n1_bradial_parameters #500
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
D3DPhysicsMethods.get_n1_bradial_parameterswhich was previously removed in release v0.8 (Release v0.8 #263)D3DPhysicsMethods.get_btorand use it inget_n1_bradial_parametersandget_n1rms.n_equal_1_mode,n_equal_1_normalized(tested & XFAIL), andbtor(not tested)Notes on testing
n_equal_1_modeandn_equal_1_normalizedare both marked asXFAILas all 4 testing shots fall within the range of shots where the raw signal data need to be retrieved from files previously stored oniris.DISRUPTION_WARNINGtable and the outputs from this physics method match the data in the table.DISRUPTION_WARNINGtable. I found out that these stored data match those from the legacy DUD system (fallback data source in the method's logic) instead of the ONFR system which is available for this shot.Future TODO