Use integer math only, dropping use of long double sample rate #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanvolz
changed the title
ryanvolz
force-pushed
the
integer_math_only
branch
2 times, most recently
from
3b3c113 to
16657f0
Compare
ryanvolz
force-pushed
the
integer_math_only
branch
from
16657f0 to
70bfef7
Compare
ryanvolz
force-pushed
the
integer_math_only
branch
3 times, most recently
from
4151ba4 to
5b83fad
Compare
ryanvolz
force-pushed
the
integer_math_only
branch
3 times, most recently
from
3581eff to
502b5ec
Compare
ryanvolz
force-pushed
the
integer_math_only
branch
5 times, most recently
from
830b559 to
b69eb11
Compare
This does away with use of `np.longdouble`s for calculations with the sample rate in the Python library, which was used to get the list of files containing a given sample index range. See 90cdb49 for the commit that does the same thing in the C library. This commit also exposes two new functions to the C API: `digital_rf_get_timestamp_floor` and `digital_rf_get_sample_ceil`. These are now used to do the file sample bound calculations, and they are exposed so that users of the library can perform these calculations in a way that is consistent with what is done internally. These functions have also been exposed in the Python binding, and a test that verifies that the sample index round-trips through them is included in the Python testing suite. Because of the added C functions, the library version has been bumped to 2.7, which means the next release of Digital RF will be 2.7.0.
ryanvolz
force-pushed
the
integer_math_only
branch
from
b69eb11 to
7bddb64
Compare
This reuses the logic from the equivalent C functions to write these Python functions in a way that lets them handle array inputs.
ryanvolz
force-pushed
the
integer_math_only
branch
from
ffcf228 to
6231cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does away with use of
long doubles for calculations with the sample rate. In the C library, this was used indigital_rf_get_subdir_fileto determine file names and sample bounds. Thenp.longdoublesample rate was similarly used in the Python library to get the list of files containing a given sample index range.The reason for this change is that not all platforms support
long doubles with at least a 64-bit mantissa. This caused at least one bug on the aarch64 platform which resulted in incorrect file bounds fromdigital_rf_get_subdir_file. By using integer math that is implemented uniformly on all platforms, any bugs in the calculation should be more noticeable.This commit also adds two new functions to the C API:
digital_rf_get_timestamp_flooranddigital_rf_get_sample_ceil. These are now used to do the file sample bound calculations, and they are exposed so that users of the library can perform these calculations in a way that is consistent with what is done internally. These functions have also been exposed in the Python binding, and a test that verifies that the sample index round-trips through them is included in the Python testing suite.Because of the added C functions, the library version has been bumped to 2.7, which means the next release of Digital RF will be 2.7.0.