USE-257-fulltext #374
Merged
USE-257-fulltext #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * A new field, fulltext, is needed for TIMDEX sources How this addresses that need: * Update opensearch_mappings.json to include fulltext field during searching but exclude it from retrieval * Add configure_index_settings unit test to confirm fulltext field is present in the loaded mapping * Update dependencies Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-257
ghukill
approved these changes
Dec 16, 2025
Contributor
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Looks great! As you noted, not much code churn here, but thanks for the legwork confirming that it works.
Excellent foot in the door for full-text searching here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Adds
fulltextfield to mapping for searching but excludes it from retrieval.How can a reviewer manually see the effects of these changes?
I reindexed
mitlibwebsiteonDev1and confirmed the fulltext is indexed when I searched for each DataEng member's last name (hat tip @ghukill). This brought up our respective Staff Directory page despite our last name not appearing in any other fields for that page.To repeat this check:
Dev1OpenSearch dashboard:GET mitlibwebsite/_search?q=<staff member last name>as seen below:Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review