Create find_proxy function for local outcome#519
Open
laleoarrow wants to merge 2 commits intoMRCIEU:masterfrom
Open
Create find_proxy function for local outcome#519laleoarrow wants to merge 2 commits intoMRCIEU:masterfrom
find_proxy function for local outcome#519laleoarrow wants to merge 2 commits intoMRCIEU:masterfrom
Conversation
### Summary This PR adds a local proxy SNP search function to the TwoSampleMR package. This function allows users to find proxy SNPs locally with or without relying on external databases, enhancing the package's usability and functionality. ### Details - Added a new script `find_proxy.R` under the `R` directory. - Implemented a function to search for proxy SNPs for local data, which is not available in the current tsmr package. - Updated example use in `find_proxy.R`, which can easily be used in line with tsmr pipeline. ### Motivation Finding proxy SNPs is a critical step in many MR analyses. By providing a local search function, we can support users who have specific datasets or need offline capabilities. ### Testing Tested the function with several example datasets to ensure accuracy and performance, which are documented in the comments within the added script. ### Additional Notes First of all, totally big fan of your team and the great work you do. This PR adds only one file, `find_proxy.R`, under the `R` directory. This should help the maintainer easily check and review the changes. If this idea is accepted but requires more details, please feel free to contact me via GitHub. I am happy to contribute further to the TwoSampleMR package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a local proxy SNP search function to the TwoSampleMR package. This function allows users to find proxy SNPs locally with or without relying on external databases, enhancing the package's usability and functionality.
Details
find_proxy.Runder theRdirectory.find_proxy.R, which can easily be used in line with tsmr pipeline.Motivation
Finding proxy SNPs is a critical step in many MR analyses. By providing a local search function, we can support users who have specific datasets or need offline capabilities.
Testing
Tested the function with several iv datasets in our case to ensure accuracy and performance, which are documented in the comments within the added script.
Additional Notes
First of all, totally big fan of your team and the great work you do. This PR adds only one file,
find_proxy.R, under theRdirectory. This should help the maintainer easily check and review the changes. If this idea is accepted but requires more details, please feel free to contact me via GitHub. I am happy to contribute further to the TwoSampleMR package.