Fix for get_pref_managed() when a temporary configuration is used #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.1.0 rc1 json update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a temporary workflow is used, there is a logic error in the get_pref_managed function.
On line 1140, it tries to get the data-type of the preference setting that's being checked to transform any boolean to the string equivalent ("True" or "False"). However, this check is done on the main configuration plist instead of the temporary configuration plist. If the key is not present in the main plist, then it defaults to returning the value of a key that does not exists.
This leads to an issue when checking for settings that are not in the main plist but that are in the temporary one.
This is fixed by checking the good plist if a temporary workflow is used and that the override key is set.