Fix missing ProfileVersionQuery method from mock profile stores
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR let's you access
ProfileVersionQueryfrom mock profile stores - silently failingquery:Nextrequests. While profiles will never load corrupted from a profile store, there is still no good reason for the method to error out upon usage, for consistency with other API, it should just silently fail, allowing developer code to still safely run in test-environments (where developer manually tries to corrupt a profile loaded from a mock profile store), instead of forcing the developer to have a check for using a specific portion of the API.