Skip to content

Conversation

@NickLaMuro
Copy link
Member

@NickLaMuro NickLaMuro commented May 8, 2020

This is a rebase of #412

This only required the update of spec/lib/github_service_spec.rb to be modified to work with the new GithubService specs that were added back in 1173807 to support #username_lookup (since both commits added this file back).

See #412 for details on this feature.

Links

Commits are marked with [success/error] state depending on offence detection. If there are any offences in the code, the commit is marked with error state otherwise with success state. It is reflected at the end of PR in the check conclusion part.
@NickLaMuro
Copy link
Member Author

@europ FYI: This is just a rebase of your work. If you want to pull it into your branch, that would work too and I can close this one.

Same goes for #500 (though, that one is a bit more complex with it's changes and rational)

@miq-bot
Copy link
Member

miq-bot commented May 8, 2020

Checked commit NickLaMuro@2fd3afb with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
4 files checked, 2 offenses detected

spec/lib/github_service_spec.rb

spec/workers/commit_monitor_handlers/commit_range/rubocop_checker_spec.rb

@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the GitHub's Checks API (fka Statuses API)

6 participants