Refactor Manual Core format to allow separation from data files#122
Draft
qwint wants to merge 3 commits intoManualForArchipelago:mainfrom
Draft
Refactor Manual Core format to allow separation from data files#122qwint wants to merge 3 commits intoManualForArchipelago:mainfrom
qwint wants to merge 3 commits intoManualForArchipelago:mainfrom
Conversation
… game data format, and includes a simple way to import a ".manuworld" without hooks for a safer import TODOs: * flesh out the codepath where you do want to import hooks * Options.make_options_group is completely broken and its uses commented out
Contributor
|
Thanks for submitting this PoC, qwint. 😃 From the description, it sounds like this is an unfinished PR, so please switch it to a draft PR in the meantime. We review drafts as well, but marking it as a draft indicates that it's not expected to be ready to merge once reviews are complete. |
Contributor
Author
|
yea, it's fully functional in the one codepath of load all the ".manuworld" files as json-only from the user's custom_worlds (or userdata worlds on machines that use that instead), but like the TODOs mention it does break some existing functionality so it probably shouldn't be merged as-is yet |
FuzzyGamesOn
added
the
needs internal discussion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds framework to split out manual core files from the shipped manual game data format, and includes a simple way to import a ".manuworld" (theoretically can just be a .zip if that makes more sense) without hooks for a safer import
TODOs:
figure out if one of the changes is why manual client hangs on launch and fix itI'm not sure I'll finish this to completion, so if anyone wants to take inspiration (or the entire branch wholesale) feel free to do so
but can obviously make/approve minor changes for style/design