Skip to content

FIX ICON #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkE16 merged 1 commit into from
Aug 11, 2025
Merged

FIX ICON #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/Navbar/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import NavbarFileSaveStatus from "../NavbarFileSaveStatus/NavbarFileSaveStatus";
import ZoomIn from "../icons/ZoomIn/ZoomIn";
import { detectOperatingSystem } from "@/lib/utils";
import ZoomOut from "../icons/ZoomOut/ZoomOut";

function Navbar(): ReactNode {
const {
Expand All @@ -39,7 +40,7 @@
decreaseScale
} = useStore(
useShallow((state) => ({
prepareForExport: state.prepareForExport,

Check failure on line 43 in src/components/Navbar/Navbar.tsx

View workflow job for this annotation

GitHub Actions / Vitest

src/tests/integration/Page.test.tsx > Page > should close the reference window from the close button 

TestingLibraryElementError: Unable to find an accessible element with the role "menuitem" and name "View"

Here are the accessible roles:

  heading:

  Name "Uh oh. Something went wrong.":
  <h1 />

  --------------------------------------------------
  paragraph:

  Name "":
  <p />

  --------------------------------------------------
  link:

  Name "here":
  <a
    href="https://github.com/MarkE16/LiveCanvas/issues"
  />

  --------------------------------------------------
  group:

  Name "":
  <details />

  --------------------------------------------------

Ignored nodes: comments, script, style
<body>
  <div>
    <div>
      <h1>
        Uh oh. Something went wrong.
      </h1>
      <p>
        Something you did caused an error. It is recommended that you report this error by submitting an issue 
        <a
          href="https://github.com/MarkE16/LiveCanvas/issues"
        >
          here
        </a>
        .
      </p>
      <details>
        <summary>
          Click for more info
        </summary>
        <pre>
          Error: Unsupported operating system detected: Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/25.0.1
        </pre>
        <pre>
          
    at Navbar (/home/runner/work/LiveCanvas/LiveCanvas/src/components/Navbar/Navbar.tsx:43:27)
    at ErrorBoundary (/home/runner/work/LiveCanvas/LiveCanvas/src/components/ErrorBoundary/ErrorBoundary.tsx:8:5)
    at StoreProvider (/home/runner/work/LiveCanvas/LiveCanvas/src/components/StoreContext/StoreContext.tsx:8:26)
    at Page (/home/runner/work/LiveCanvas/LiveCanvas/src/pages/index/index.page.tsx:30:25)
    at StoreProvider (/home/runner/work/LiveCanvas/LiveCanvas/src/components/StoreContext/StoreContext.tsx:8:26)
    at ThemeProvider (/home/runner/work/LiveCanvas/LiveCanvas/src/components/ThemeProvider/ThemeProvider.tsx:13:3)
    at Wrapper (/home/runner/work/LiveCanvas/LiveCanvas/src/tests/test-utils.tsx:18:22)
        </pre>
      </details>
    </div>
  </div>
</body>
 ❯ Navbar src/components/Navbar/Navbar.tsx:43:27
 ❯ ErrorBoundary src/components/ErrorBoundary/ErrorBoundary.tsx:8:5
 ❯ StoreProvider src/components/StoreContext/StoreContext.tsx:8:26
 ❯ Page src/pages/index/index.page.tsx:30:25
 ❯ StoreProvider src/components/StoreContext/StoreContext.tsx:8:26
 ❯ ThemeProvider src/components/ThemeProvider/ThemeProvider.tsx:13:3
 ❯ Object.getElementError node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/config.js:37:19
 ❯ node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
 ❯ node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
 ❯ node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
 ❯ src/tests/integration/Page.test.tsx:42:26

Check failure on line 43 in src/components/Navbar/Navbar.tsx

View workflow job for this annotation

GitHub Actions / Vitest

src/tests/integration/Page.test.tsx > Page > should open the reference window from the View menu 

TestingLibraryElementError: Unable to find an accessible element with the role "menuitem" and name "View"

Here are the accessible roles:

  heading:

  Name "Uh oh. Something went wrong.":
  <h1 />

  --------------------------------------------------
  paragraph:

  Name "":
  <p />

  --------------------------------------------------
  link:

  Name "here":
  <a
    href="https://github.com/MarkE16/LiveCanvas/issues"
  />

  --------------------------------------------------
  group:

  Name "":
  <details />

  --------------------------------------------------

Ignored nodes: comments, script, style
<body>
  <div>
    <div>
      <h1>
        Uh oh. Something went wrong.
      </h1>
      <p>
        Something you did caused an error. It is recommended that you report this error by submitting an issue 
        <a
          href="https://github.com/MarkE16/LiveCanvas/issues"
        >
          here
        </a>
        .
      </p>
      <details>
        <summary>
          Click for more info
        </summary>
        <pre>
          Error: Unsupported operating system detected: Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/25.0.1
        </pre>
        <pre>
          
    at Navbar (/home/runner/work/LiveCanvas/LiveCanvas/src/components/Navbar/Navbar.tsx:43:27)
    at ErrorBoundary (/home/runner/work/LiveCanvas/LiveCanvas/src/components/ErrorBoundary/ErrorBoundary.tsx:8:5)
    at StoreProvider (/home/runner/work/LiveCanvas/LiveCanvas/src/components/StoreContext/StoreContext.tsx:8:26)
    at Page (/home/runner/work/LiveCanvas/LiveCanvas/src/pages/index/index.page.tsx:30:25)
    at StoreProvider (/home/runner/work/LiveCanvas/LiveCanvas/src/components/StoreContext/StoreContext.tsx:8:26)
    at ThemeProvider (/home/runner/work/LiveCanvas/LiveCanvas/src/components/ThemeProvider/ThemeProvider.tsx:13:3)
    at Wrapper (/home/runner/work/LiveCanvas/LiveCanvas/src/tests/test-utils.tsx:18:22)
        </pre>
      </details>
    </div>
  </div>
</body>
 ❯ Navbar src/components/Navbar/Navbar.tsx:43:27
 ❯ ErrorBoundary src/components/ErrorBoundary/ErrorBoundary.tsx:8:5
 ❯ StoreProvider src/components/StoreContext/StoreContext.tsx:8:26
 ❯ Page src/pages/index/index.page.tsx:30:25
 ❯ StoreProvider src/components/StoreContext/StoreContext.tsx:8:26
 ❯ ThemeProvider src/components/ThemeProvider/ThemeProvider.tsx:13:3
 ❯ Object.getElementError node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/config.js:37:19
 ❯ node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
 ❯ node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
 ❯ node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
 ❯ src/tests/integration/Page.test.tsx:31:26

Check failure on line 43 in src/components/Navbar/Navbar.tsx

View workflow job for this annotation

GitHub Actions / Vitest

src/tests/integration/Page.test.tsx > Page > should render the page 

TestingLibraryElementError: Unable to find an element by: [data-testid="nav-bar"]

Ignored nodes: comments, script, style
<body>
  <div>
    <div>
      <h1>
        Uh oh. Something went wrong.
      </h1>
      <p>
        Something you did caused an error. It is recommended that you report this error by submitting an issue 
        <a
          href="https://github.com/MarkE16/LiveCanvas/issues"
        >
          here
        </a>
        .
      </p>
      <details>
        <summary>
          Click for more info
        </summary>
        <pre>
          Error: Unsupported operating system detected: Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/25.0.1
        </pre>
        <pre>
          
    at Navbar (/home/runner/work/LiveCanvas/LiveCanvas/src/components/Navbar/Navbar.tsx:43:27)
    at ErrorBoundary (/home/runner/work/LiveCanvas/LiveCanvas/src/components/ErrorBoundary/ErrorBoundary.tsx:8:5)
    at StoreProvider (/home/runner/work/LiveCanvas/LiveCanvas/src/components/StoreContext/StoreContext.tsx:8:26)
    at Page (/home/runner/work/LiveCanvas/LiveCanvas/src/pages/index/index.page.tsx:30:25)
    at StoreProvider (/home/runner/work/LiveCanvas/LiveCanvas/src/components/StoreContext/StoreContext.tsx:8:26)
    at ThemeProvider (/home/runner/work/LiveCanvas/LiveCanvas/src/components/ThemeProvider/ThemeProvider.tsx:13:3)
    at Wrapper (/home/runner/work/LiveCanvas/LiveCanvas/src/tests/test-utils.tsx:18:22)
        </pre>
      </details>
    </div>
  </div>
</body>
 ❯ Navbar src/components/Navbar/Navbar.tsx:43:27
 ❯ ErrorBoundary src/components/ErrorBoundary/ErrorBoundary.tsx:8:5
 ❯ StoreProvider src/components/StoreContext/StoreContext.tsx:8:26
 ❯ Page src/pages/index/index.page.tsx:30:25
 ❯ StoreProvider src/components/StoreContext/StoreContext.tsx:8:26
 ❯ ThemeProvider src/components/ThemeProvider/ThemeProvider.tsx:13:3
 ❯ Object.getElementError node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/config.js:37:19
 ❯ node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
 ❯ node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
 ❯ node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
 ❯ src/tests/integration/Page.test.tsx:26:17
prepareForSave: state.prepareForSave,
toggleReferenceWindow: state.toggleReferenceWindow,
increaseScale: state.increaseScale,
Expand Down Expand Up @@ -144,7 +145,7 @@
{
text: "Zoom Out",
action: decreaseScale,
icon: ZoomIn,
icon: ZoomOut,
shortcut: "Minus"
},
{
Expand Down
Loading