Implementing an UI to enable users create their own courses#13
Open
Implementing an UI to enable users create their own courses#13
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Mau-MD
added
the
waiting for another pr
Mau-MD
changed the title
nosoyilse
reviewed
Aug 4, 2022
Collaborator
nosoyilse
left a comment
nosoyilse
left a comment
There was a problem hiding this comment.
LGTM!
Very descriptive function names! Readability of the function names is very good!
I will divide the UI and the backend into separate PRs
| export const saveResources = async ( | ||
| resources: IWeightedYoutubeVideo[], | ||
| course: Parse.Object<Parse.Attributes>, | ||
| level: 1 | 2, |
Collaborator
There was a problem hiding this comment.
You can use an enum here, so that we can now what level 1 and 2 mean:
Owner
Author
There was a problem hiding this comment.
I didn't know Enums even existed on Typescript! Thanks for letting me know!!
nosoyilse
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App Context
Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.
PR Context
We do have the backend endpoints to create a new course given a name query, but we don't have an ui nor logic to actually make that possible.
This PR
Adds the necessary logic to make the form work and submit it to the backend. It also adds a Middleware in the backend that fetches a user given a session token in the auth headers
CleanShot.2022-07-19.at.16.19.16.mp4
Next
Create the necessary routes to fetch the resources from the backend and display them in the UI already created.
IMPORTANT:
Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: Adding formik to new course form
How to preview a PR on Vercel
/loginand log in with usernameadminand passwordadmin123/dashboard