Skip to content

Adding loading state when the frontend is fetching from the backend inside the Course UI#15

Open
Mau-MD wants to merge 79 commits intomainfrom
loading_state
Open

Adding loading state when the frontend is fetching from the backend inside the Course UI#15
Mau-MD wants to merge 79 commits intomainfrom
loading_state

Conversation

@Mau-MD
Copy link
Owner

@Mau-MD Mau-MD commented Jul 19, 2022

App Context

Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.

PR Context

Currently the app can fetch and display in the ui the courses the user is currently enrolled in, but nothing indicates if the content is loading or not.

This PR

Adds a skeleton component and multiple spinners to indicate that the content is fetching

CleanShot.2022-07-19.at.16.55.24.mp4

Next

Use an Image API to display cover images in the Course Cards

IMPORTANT:

Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: Adding loading card in dashboard

How to preview a PR on Vercel

  • Go to /login and log in with username admin and password admin123
  • Go to /dashboard

@vercel
Copy link

vercel bot commented Jul 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learning-u ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 11:59PM (UTC)

@Mau-MD Mau-MD assigned Mau-MD and unassigned Mau-MD Jul 19, 2022
@Mau-MD Mau-MD requested review from ImaMonsta and nosoyilse July 19, 2022 23:59
@Mau-MD Mau-MD added the waiting for another pr Another PR needs to be approved before this gets reviewed label Jul 19, 2022
Copy link
Collaborator

@nosoyilse nosoyilse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice PR size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for another pr Another PR needs to be approved before this gets reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants