Adding image fetching from Unplash API when creating a course, so it looks pretty in the frontend :)#16
Open
Adding image fetching from Unplash API when creating a course, so it looks pretty in the frontend :)#16
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Mau-MD
added
the
waiting for another pr
nosoyilse
reviewed
Aug 4, 2022
| return resources; | ||
| }; | ||
|
|
||
| export const getResourcesFromCourseAndDifficulty = async ( |
Collaborator
There was a problem hiding this comment.
nit: This function name threw me off a little bit, maybe getResourcesFromCourseWithDifficulty
nosoyilse
reviewed
Aug 4, 2022
| courseId: string; | ||
| started?: boolean; | ||
| phrase: string; | ||
| difficulty: 1 | 2; |
Collaborator
There was a problem hiding this comment.
You can use an enum in here, it will bring clarity to what this difficulty mean.
For instance is 1 the more difficult? or is it 2?
If you use an enum that becomes clear
enum Difficulty {
Easy = 1,
Medium,
Advanced
}
nosoyilse
approved these changes
Aug 4, 2022
| @@ -0,0 +1,9 @@ | |||
| import { IResource } from "../types/resource"; | |||
|
|
|||
| export const calculateCourseCompletition = (resources: IResource[]) => { | |||
Collaborator
There was a problem hiding this comment.
does this function has to do with this PR?
nosoyilse
reviewed
Aug 4, 2022
| > | ||
| {kind === "video" && ( | ||
| <> | ||
| {kind === "video" && |
Collaborator
There was a problem hiding this comment.
Owner
Author
There was a problem hiding this comment.
Since we are not using documentation type resources, I think im gonna delete it from both the backend and frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App Context
Learning U is a platform where software engineers can go and learn new technologies in an organized way. They can track their progress and get suggestions about what courses to take in both visual and written ways.
PR Context
Right now the Course and Difficulty Cards have placeholder images and they do not belong to the course that is being generated.
This PR
When creating a course, it fetches from Unsplash API using the course name and gets images that are then returned to the frontend and displayed there. So if a user makes a course about
Reactthe Course Card will have an image about React there.CleanShot.2022-07-19.at.17.05.04.mp4
Next
Fix some styling issues
IMPORTANT:
Since this PR was based in another one, a lot of commits appear here even if they are not related to this PR. In reaility commits start here: adding types for unsplash image links
How to preview a PR on Vercel
/loginand log in with usernameadminand passwordadmin123/dashboard