Skip to content

added full test#101

Open
michaelarena wants to merge 4 commits intomainfrom
mkidpipe_test
Open

added full test#101
michaelarena wants to merge 4 commits intomainfrom
mkidpipe_test

Conversation

@michaelarena
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 23, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ld-cd
Copy link
Contributor

ld-cd commented Aug 23, 2024

Whoops those shouldn't pass...

@ld-cd
Copy link
Contributor

ld-cd commented Aug 23, 2024

Ah

@ld-cd
Copy link
Contributor

ld-cd commented Aug 23, 2024

Free tier won't be good enough here, I'll need to generate bin files on the fly I think :(

@ld-cd
Copy link
Contributor

ld-cd commented Aug 26, 2024

Running with the full dataset we still get the same error we get with this test and the reduced dataset:

2024-08-25 14:38:53 mkidpipeline.steps.flatcal  :INFO     (make_spectral_cube:362[pid=3898002]) Loaded 850.0 nm spectral cube
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/mkidpipe.py", line 175, in <module>
    sys.exit(mainmain())
             ^^^^^^^^^^
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/mkidpipe.py", line 172, in mainmain
    return main(args)
           ^^^^^^^^^^
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/mkidpipe.py", line 159, in main
    pipe.PIPELINE_STEPS[step].fetch(getattr(outputs, f"{step}s"))
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 564, in fetch
    f.run()
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 125, in run
    self.load_flat_spectra()
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 145, in load_flat_spectra
    self.make_spectral_cube()
  File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 363, in make_spectral_cube
    cps_cube_list[:, :, :, w_idx] = hdul['SCIENCE'].data
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
ValueError: could not broadcast input array from shape (0,140,146) into shape (6,140,146)

@ld-cd
Copy link
Contributor

ld-cd commented Aug 26, 2024

@ld-cd
Copy link
Contributor

ld-cd commented Sep 3, 2024

We now have a binfile generator https://mazinlab.github.io/binney/binney.html#BinSerializer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants