Open
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Contributor
|
Whoops those shouldn't pass... |
Contributor
|
Ah |
Contributor
|
Free tier won't be good enough here, I'll need to generate bin files on the fly I think :( |
Contributor
|
Running with the full dataset we still get the same error we get with this test and the reduced dataset: 2024-08-25 14:38:53 mkidpipeline.steps.flatcal :INFO (make_spectral_cube:362[pid=3898002]) Loaded 850.0 nm spectral cube
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/mkidpipe.py", line 175, in <module>
sys.exit(mainmain())
^^^^^^^^^^
File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/mkidpipe.py", line 172, in mainmain
return main(args)
^^^^^^^^^^
File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/mkidpipe.py", line 159, in main
pipe.PIPELINE_STEPS[step].fetch(getattr(outputs, f"{step}s"))
File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 564, in fetch
f.run()
File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 125, in run
self.load_flat_spectra()
File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 145, in load_flat_spectra
self.make_spectral_cube()
File "/work/cudaa/PipelineTest/MKIDPipeline/mkidpipeline/steps/flatcal.py", line 363, in make_spectral_cube
cps_cube_list[:, :, :, w_idx] = hdul['SCIENCE'].data
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
ValueError: could not broadcast input array from shape (0,140,146) into shape (6,140,146) |
Contributor
Contributor
|
We now have a binfile generator https://mazinlab.github.io/binney/binney.html#BinSerializer |
4c3def8 to
ac4ef62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.