Replaced progressbar with tqdm + Replaced pkg_resources with importlib.resources + Edit to .github/workflows/main.yaml#113
Draft
Replaced progressbar with tqdm + Replaced pkg_resources with importlib.resources + Edit to .github/workflows/main.yaml#113
Conversation
added 5 commits
August 27, 2024 11:28
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 19.82% 20.00% +0.17%
==========================================
Files 26 27 +1
Lines 7580 7583 +3
==========================================
+ Hits 1503 1517 +14
+ Misses 6077 6066 -11 ☔ View full report in Codecov by Sentry. |
…lish-package job.
2714495 to
2da025a
Compare
2da025a to
196eec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces progressbar used in lincal and wavecal steps with tqdm. Closes issue #94. Also partly closes issue #97. (#97 is also closed by my pull request on mkidcore side). Also a small edit to .github/workflows/main.yaml to close issue #121.