Skip to content

Replaced progressbar with tqdm + Replaced pkg_resources with importlib.resources + Edit to .github/workflows/main.yaml#113

Draft
dnearing wants to merge 17 commits intomainfrom
pipeline_test1
Draft

Replaced progressbar with tqdm + Replaced pkg_resources with importlib.resources + Edit to .github/workflows/main.yaml#113
dnearing wants to merge 17 commits intomainfrom
pipeline_test1

Conversation

@dnearing
Copy link
Collaborator

@dnearing dnearing commented Aug 27, 2024

Replaces progressbar used in lincal and wavecal steps with tqdm. Closes issue #94. Also partly closes issue #97. (#97 is also closed by my pull request on mkidcore side). Also a small edit to .github/workflows/main.yaml to close issue #121.

@dnearing dnearing closed this Aug 27, 2024
@dnearing dnearing reopened this Aug 27, 2024
@codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 20.00%. Comparing base (d9be32a) to head (2714495).

Files with missing lines Patch % Lines
mkidpipeline/steps/lincal.py 20.00% 4 Missing ⚠️
mkidpipeline/steps/wavecal.py 20.00% 4 Missing ⚠️
tests/test_tqdm.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   19.82%   20.00%   +0.17%     
==========================================
  Files          26       27       +1     
  Lines        7580     7583       +3     
==========================================
+ Hits         1503     1517      +14     
+ Misses       6077     6066      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnearing dnearing changed the title Pipeline test1 Replaced progressbar with tqdm Aug 27, 2024
Copy link
Contributor

@ld-cd ld-cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

@dnearing dnearing requested a review from ld-cd September 9, 2024 22:14
@dnearing dnearing changed the title Replaced progressbar with tqdm Replaced progressbar with tqdm + Replaced pkg_resources with importlib.resources Sep 10, 2024
@dnearing dnearing changed the title Replaced progressbar with tqdm + Replaced pkg_resources with importlib.resources Replaced progressbar with tqdm + Replaced pkg_resources with importlib.resources + Edit to .github/workflows/main.yaml Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants