Conversation
…both decrease pixcal memory usage and also not allow it to eat up all the ram on dark/glados
This reverts commit 22ed7fd.
…le times and not the file for the metadata header build query.
…al needs to match that of the photons.
Upgrading to 3.10
Co-authored-by: nzivkov <nzivkov@example.com>
added publish-package to main.yaml
Add pdoc to pyproject.toml, deleted legacy directory
release 1.9.0, changed mkidcore dependency to pypi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original wavecal was only using gaussian and exponential. This change introduces all three model classes from wavecal_models.py, GaussianAndGaussian, GaussianAndExponential, and GaussianAndGaussianExponential sequentially. The new wavecal also has smaller binning to encourage a fit even for unstable pixels. This change yields higher pixel counts in the final image. To use only one or two of these models, and to constrain the amount of pixels that pass through the calibration, you can manually comment out the models in the wavecal.py file.