Fix default minheight not being -64, adjusting it to the correct min build height for vanilla minecraft for correct mob spawning in deep caves.#540
Open
Corosauce wants to merge 2 commits intoMcJtyMods:1.21_neofrom
Conversation
…ights, fixes nothing spawning deep in the caves
Collaborator
|
I actually don't want this. I regret making the decision to default this. In future versions of In Control it will be required to specify this |
Author
|
Ah gotcha 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla minecraft caves go as far as -64 now, incontrol is still defaulting the minheight to 1, this PR fixes that so things can spawn deep in the caves correctly.
Before this fix it was required to manually specify your own minheight of -64 in the json to work around it.