Fix extract fluid filter not working and allow multi-tank extraction#523
Open
StevenDoesStuffs wants to merge 1 commit intoMcJtyMods:1.16from
Open
Fix extract fluid filter not working and allow multi-tank extraction#523StevenDoesStuffs wants to merge 1 commit intoMcJtyMods:1.16from
StevenDoesStuffs wants to merge 1 commit intoMcJtyMods:1.16from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the problem where the extract fluid filter wasn't being applied (surprised this hasn't already been reported, or at least I can't find it).
Also, the network will now try to extract fluids from other tanks in the same block when the default one "fails".
Basically should close stuff like #504, (the first part of) #358, and #320.
I might take a crack at the second part of #358 later.