111 covenant data is no longer included in midnight simc data #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates all code, tests, and models related to parsing and handling conduits and soulbinds, including their extraction, storage, and spell mapping.
Changed default branch to 'midnight' in CacheService and removed CovenantData file configuration. Updated project version to 3.0.0 and bumped NuGet package dependencies to latest minor versions.
Revert the change to midnight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes all code, data models, and tests related to "Covenant", "Soulbinds", and "Conduits" from the SimcProfileParser project. The changes also update the data sync logic to reflect the removal of conduit data.