Skip to content

Conversation

@Niphyr
Copy link
Contributor

@Niphyr Niphyr commented Oct 25, 2025

This pull request introduces substantial improvements to the documentation.

  • The README.md now includes detailed usage examples for profile parsing, item and spell generation, talent retrieval, configuration (game version switching), caching, supported data types, limitations, and error handling.
  • The SimcGenerationService class and its methods are now thoroughly documented with XML comments, describing constructors, parameters, exceptions, and usage scenarios.
  • The default game data branch is updated from "thewarwithin" to "midnight" in both the code (CacheService) and tests and a version bump is included.
  • README now documents all major exception types that the library may throw.

@Niphyr Niphyr self-assigned this Oct 25, 2025
@Niphyr Niphyr added the documentation Improvements or additions to documentation label Oct 25, 2025
@Niphyr Niphyr linked an issue Oct 25, 2025 that may be closed by this pull request
- Includes fixed tests
@Niphyr Niphyr merged commit 0127b4d into master Oct 25, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update documentation to be more feature complete

2 participants