Improve cache logic to load outdated files #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces RawFileService to handle raw file downloads, ETag validation, and cache management. CacheService now delegates raw file operations to RawFileService. Updates related tests and interfaces to support the new service. FileETag model extended with LastChecked property for ETag revalidation logic.
This also fixes #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
CacheServiceand related test initialisation to improve dependency management and cache validation logic. The main changes include injecting the newRawFileServicedependency.Dependency Injection and Initialisation
RawFileServiceas a dependency toCacheService, updating its constructor and test initialisations to support this change.CacheServicefrom explicit constructors to collection initialisers for_registeredFilesand_cachedFileData.CacheServiceto use the directRegisterFileConfigurationmethod instead of casting to the interface.GetParsedFileContentsAsyncby checking disk cache validity and removing invalid files before loading new data.