Hooks2 #2
Open
Hooks2 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikdemm
reviewed
Jan 31, 2022
Comment on lines
18
to
30
| /*const fetchRepos = () => { | ||
| setRepo( "loading" ) | ||
| axios.get("https://api.github.com/user/repos", { | ||
| params: this.state.filters | ||
| params: filters | ||
| }) | ||
| .then((response) => { | ||
| this.setState({ repos: response.data }) | ||
| setRepo(response.data ) | ||
| }) | ||
| .catch((error) => { | ||
| console.log(error) | ||
| this.setState({ repos: [] }) | ||
| setRepo( [] ) | ||
| }) | ||
| } | ||
| }*/ |
Contributor
There was a problem hiding this comment.
This outdated code is better removed to not affect code readability
Comment on lines
81
to
95
| {/*<div className="repositoies-list-navigation-buttons-container"> | ||
| <button | ||
| onClick={this.handlePrevPage} | ||
| onClick={handlePrevPage} | ||
| className="repositoies-list-navigation-button" | ||
| disabled={this.state.filters.page === 1} | ||
| disabled={filters.page === 1} | ||
| > | ||
| {"<"} | ||
| </button> | ||
| <button | ||
| onClick={this.handleNextPage} | ||
| onClick={handleNextPage} | ||
| className="repositoies-list-navigation-button" | ||
| > | ||
| {">"} | ||
| </button> | ||
| </div> | ||
| </div>*/} |
src/redux/store.js
Outdated
| @@ -0,0 +1,7 @@ | |||
| import rootReducer from "./reducers" | |||
| //import { createStore } from "@reduxjs/toolkit" | |||
src/redux/reducers/repos.reducer.js
Outdated
|
|
||
| const initialState = { | ||
| reposList: [], | ||
| filters:{page:1,per_page:10,visibility:"public"} |
Contributor
There was a problem hiding this comment.
filters can stay in the local state of the component since it is not shared with any other.
If, for some reason, we needed to have them in the store, you should dispatch new actions and handle them in the reducer to update the data from the component.
Author
There was a problem hiding this comment.
Thank you Sir for your comments, I tried to solve the bugs and update profile and repositoriesList using redux
eya26
commented
Jan 31, 2022
Author
eya26
left a comment
eya26
left a comment
There was a problem hiding this comment.
I tried to update profile and repositoriesList using redux and it's working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.