Redux refactoring #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikdemm
reviewed
Jan 31, 2022
src/components/profile/Profile.js
Outdated
Comment on lines
10
to
19
| //const [profile, setProfile] = useState({}); | ||
|
|
||
| useEffect(() => { | ||
| axios.get(`https://api.github.com/user`).then((response) => { | ||
| setProfile(response.data); | ||
| }); | ||
| }); | ||
| const dispatch = useDispatch() | ||
| const userData = useSelector((state) => state.profile.userData) | ||
|
|
||
| useEffect(() => { | ||
| dispatch(fetchProfileData()) | ||
| // axios.get(`https://api.github.com/user`).then((response) => { | ||
| // setProfile(response.data); | ||
| // }); |
Contributor
There was a problem hiding this comment.
outdated code would rather be deleted :trash:
Comment on lines
25
to
38
| // const fetchRepos = () => { | ||
| // setRepos("loading"); | ||
| // axios | ||
| // .get("https://api.github.com/user/repos", { | ||
| // params: filters, | ||
| // }) | ||
| // .then((response) => { | ||
| // setRepos(response.data); | ||
| // }) | ||
| // .catch((error) => { | ||
| // console.log(error); | ||
| // setRepos([]); | ||
| // }); | ||
| // }; |
Contributor
There was a problem hiding this comment.
Same for this. Leaving commented outdated code will affect code readability
src/store/actions/profile.action.js
Outdated
| const fetchProfileData = createAsyncThunk( | ||
| 'profile/fetchProfileData', | ||
| async () => { | ||
| const res = await axios.get('https://api.github.com/user') |
Contributor
There was a problem hiding this comment.
Why don't we abstract the baseUrl https://api.github.com and make it an environment variable in .env
src/store/actions/repos.actions.js
Outdated
| const fetchRepos = createAsyncThunk( | ||
| 'repos/fetchRepos', | ||
| async () => { | ||
| const res = await axios.get('https://api.github.com/user/repos') |
Contributor
There was a problem hiding this comment.
If we abstract the baseUrl and make it an environment variable we will directly use it here.
If for some reason, we or the thrid party (github) are changing the url, we will change it once
Author
|
@Ikdemm I'll make sure to apply the fixes and commit right away ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux Store setup including :
🦇