build: add conditional autoreconf #398
Conversation
g-maxime
left a comment
g-maxime
left a comment
There was a problem hiding this comment.
I have nothing against the changes in autogen.sh itself.
But autotools aren't supposed to be run by the final user.
Extra, this fail on our macOS build environment:
configure.ac:29: error: possibly undefined macro: AC_PROG_LIBTOOL If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /opt/local/bin/autoconf failed with exit status: 1
| else | ||
| automake -a | ||
| chmod a+x configure | ||
| if [ -z "$NOCONFIGURE" ]; then |
There was a problem hiding this comment.
I am reluctant to have default behavior to launch ./configure, it is not the previous behavior and autogen.sh is planned for generating files for the final user, here we would have to change our build scripts in other places if we don't want to launch unnecessarily ./configure.
I am fine with that if autotools are installed, especially if it prevents the user to launch our scripts (I understand from the issue ticket that they fail if autotools is installed).
Maybe a warning already existing due to the bad |
3 participants
No description provided.