Support CensoredASM's onDemandAnimatedTextures feature#87
Support CensoredASM's onDemandAnimatedTextures feature#87embeddedt wants to merge 1 commit intoMeldexun:mainfrom
Conversation
|
This PR seems to break Nothirium's current compatibility with OptiFine. I built a .jar myself, and when I tried to use it along with Optifine, the game will crash on entering main menu: But it works pretty great without OptiFine installed. The original Nothirium works with and without OptiFine installed. |
|
This PR seems pretty invasive just to support this single feature. I'm currently in the process of some larger updates for Nothirium which means I will delay this PR until I have finished my updates. |
|
It seems that the compatibility issue introduced by this PR (see my last comment) is actually pretty easy to fix. An additional null check is enough for fixing this. See ZZZank@a18de8c - if(!LOADED)
+ if(!LOADED || ChunkRenderManager.getRenderer() == null)I've tested this in E2EE modpack, and there's no crash during 3 hours of gameplay. |
|
given that there have been at least 4 people reaching out to me to ask how to build this PR with my minor fix, I'm providing an example build at https://github.com/ZZZank/Nothirium/releases/tag/v1.12.2-0.3.4-on_demand_texture . Note that you need to unzip the I'm aware that this mod is ARR, so if Meldexun points out anything that my example build violates, I'll obviously delete this release. |
|
Entity flames are not properly animated, even with this PR/patch. For example if a zombie is burning from sunlight, the flame texture will be inconsistently animated based on distance from the player. |
|
will this ever get merged? it's been a while |
The patch has been structured to involve minimal changes to Nothirium's codebase; the code that interacts with CensoredASM directly is in a separate class.
Note that this requires CensoredASM 5.18 to work correctly; I have not implemented a version restriction in the initial version of this PR.