feat: Implement Platform Fee Configuration#75
Open
7maylord wants to merge 3 commits intoMentoNest:mainfrom
Open
feat: Implement Platform Fee Configuration#757maylord wants to merge 3 commits intoMentoNest:mainfrom
7maylord wants to merge 3 commits intoMentoNest:mainfrom
Conversation
Contributor
|
Hii @7maylord Please resolve Conflict |
Author
|
@ahmadogo Resolved, please review. |
Contributor
|
@7maylord One more Conflict sorry |
Author
|
Done @ahmadogo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the get_platform_fee_bps and set_platform_fee_bps feature and resolves a significant number of pre-existing bugs that prevented the contract from compiling and the test suite from running correctly.
New Feature:
closes #46