Added time period definition model #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcodicro
suggested changes
May 29, 2019
Contributor
marcodicro
left a comment
marcodicro
left a comment
There was a problem hiding this comment.
Nada grave se corrige en un minuto
|
|
||
| { #category : #'as yet unclassified' } | ||
| PeriodContextTest >> patchPeriodResponse [ | ||
| self shouldBeImplemented. |
| ] | ||
|
|
||
| { #category : #'test supporting' } | ||
| PeriodContextTest >> period [ |
Contributor
There was a problem hiding this comment.
que representa? pongamosle un buen nombre
| ] | ||
|
|
||
| { #category : #accessing } | ||
| PeriodContextTest >> periodToAdd [ |
| ] | ||
|
|
||
| { #category : #accessing } | ||
| PeriodContextTest >> periodToRemove [ |
| ] | ||
|
|
||
| { #category : #'test supporting' } | ||
| PeriodContextTest >> postPeriodResponseJson [ |
Contributor
There was a problem hiding this comment.
esto no es lo que responde la api posta. si quieren pueden revisar en postman
|
|
||
| { #category : #accessing } | ||
| PeriodContext >> periodsPath [ | ||
| ^ 'http://okr-api.mercap.net/periods' asUrl |
Contributor
There was a problem hiding this comment.
Mover basePath al Application Context
Contributor
|
@ytsejam78 @plentini finalizamos esto?? |
Contributor
Author
|
@marcodicro lo dejamos pendiente para la próxima iteración. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.